Skip to content

Adds ID field. Closes #237 - #369

Merged
rufuspollock merged 1 commit into
masterfrom
feature/id-name
Feb 7, 2017
Merged

rufuspollock merged 1 commit into
masterfrom
feature/id-name

Conversation

@pwalsh

@pwalsh pwalsh commented Feb 5, 2017

Copy link
Copy Markdown
Contributor

@pwalsh
pwalsh requested a review from rufuspollock February 5, 2017 19:51
@rufuspollock

rufuspollock commented Feb 7, 2017 •

Copy link
Copy Markdown
Contributor

@pwalsh one general comment. We seem to have moved to some quite specialized "techhy" structure for the repo - no longer plain markdown files ;-). Could we give some instructions e.g. in the README as to how the repo now works for people wanting to contribute.

It also makes PR reviewing a lot harder to read. Text seems embedded in JSON declaractions and there seems to be huge repetition in the PR ... (is there any way to get the Best of Both Worlds and have simple markdown specs and an ability to change as we need ...)

@rufuspollock

Copy link
Copy Markdown
Contributor

LTGM.

@rufuspollock
rufuspollock merged commit c080f69 into master Feb 7, 2017
@pwalsh

pwalsh commented Feb 7, 2017

Copy link
Copy Markdown
Contributor Author

I haven't gitignored one of the generated files - that creates lots of noise, so I'll fix that now.

About teaching it up: the JSON file will change to YAML which is easier for this particular purpose, but there is still plenty of markdown per spec.

@pwalsh
pwalsh deleted the feature/id-name branch February 7, 2017 06:48
@roll roll added this to datapackage Mar 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project
Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants