Skip to content
This repository was archived by the owner on May 20, 2019. It is now read-only.
This repository was archived by the owner on May 20, 2019. It is now read-only.

dpm install fails with proxy #44

Open

Description

@aubergene

dpm version 0.7.7, node 4.0.0

https_proxy=http://proxy.example.com:80 dpm install https://raw.githubusercontent.com/datasets/s-and-p-500-companies/master/datapackage.json
/usr/local/lib/node_modules/datapackage/lib/index.js:166
    if(err) return cb(err);
                   ^

ReferenceError: cb is not defined
    at Request._callback (/usr/local/lib/node_modules/datapackage/lib/index.js:166:20)
    at self.callback (/usr/local/lib/node_modules/datapackage/node_modules/request/request.js:123:22)
    at emitOne (events.js:77:13)
    at Request.emit (events.js:169:7)
    at ClientRequest.self.clientErrorHandler (/usr/local/lib/node_modules/datapackage/node_modules/request/request.js:232:10)
    at emitOne (events.js:77:13)
    at ClientRequest.emit (events.js:169:7)
    at TLSSocket.socketErrorListener (_http_client.js:259:9)
    at emitOne (events.js:77:13)
    at TLSSocket.emit (events.js:169:7)
    at emitErrorNT (net.js:1250:8)
    at doNTCallback2 (node.js:429:9)
    at process._tickCallback (node.js:343:17)

Activity

  1. added this to the milestone on May 26, 2016
  2. pwalsh commented on May 26, 2016

    @pwalsh

    @zhenyab can you please take a quick look at this.

  3. zhenyab commented on Jun 11, 2016

    @zhenyab
    Contributor

    @pwalsh I can't reproduce this bug. But looking into code it seems that it is typo on line 166:
    if(err) return cb(err);
    should be
    if(err) return callback(err);

  4. added a commit that references this issue on Jun 12, 2016
  5. added a commit that references this issue on Jun 14, 2016
  6. removed this from the milestone on Aug 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions