Repository navigation
Fix #13163 Timeline init error when one end of the time domain is empty - #13164
Open
offtherailz wants to merge 2 commits into
Open
offtherailz wants to merge 2 commits into
offtherailz wants to merge 2 commits into
Conversation
…e domain is empty
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The Timeline asks for the first and the last value of the time domain with two requests. When one of them fails or returns no value, the initialization of the range throws an error and stops, so the Timeline is not positioned on the data of the layer.
The empty values are now removed before they are processed, so the range is initialized with the available value.
The playback check that detects interval data (
setIsIntervalData) failed on the same empty value: it now ignores it too.Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x", remove the others)
Issue
What is the current behavior?
Closes #13163
What is the new behavior?
The Timeline is initialized also when only one end of the time domain is available.
Breaking change
Does this PR introduce a breaking change? (check one with "x", remove the other)