Repository navigation
Fix #13167 Migrate also the optional plugins of saved contexts - #13168
Open
offtherailz wants to merge 3 commits into
Open
offtherailz wants to merge 3 commits into
offtherailz wants to merge 3 commits into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When a context is loaded, its plugins are updated to the current version (renamed plugins and
containerPosition). The update was applied only to the plugins enabled by default, so an optional plugin of an old context, like the Timeline, was rendered in the wrong place when the user activated it.The same update is now applied also to the plugins the user can activate (
userPlugins). It is applied also when the map configuration is loaded, where the user plugins of the context are set again. The saved contexts are not modified.Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x", remove the others)
Issue
What is the current behavior?
Closes #13167
What is the new behavior?
The optional plugins of a saved context get the same migration of the plugins enabled by default.
Breaking change
Does this PR introduce a breaking change? (check one with "x", remove the other)