Repository navigation
fix: use ayatana_app_indicator_new to fix deprecated warning - #292
Open
sandikodev wants to merge 1 commit into
Open
sandikodev wants to merge 1 commit into
sandikodev wants to merge 1 commit into
Conversation
The Ayatana header marks app_indicator_new as deprecated in favor of ayatana_app_indicator_new. Use the non-deprecated function when building with the Ayatana header (the default). The legacy appindicator path still uses the old function name for backwards compatibility.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughChangesLinux system tray initialization
Estimated code review effort: 2 (Simple) | ~5 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Ayatana header marks
app_indicator_newas deprecated in favor ofayatana_app_indicator_new. This causes a-Wdeprecated-declarationswarning in every project that uses this module on Linux.This PR uses the non-deprecated function when building with the Ayatana header (the default). The legacy
USE_LEGACY_APPINDICATORpath still uses the old function name for backwards compatibility.Summary by CodeRabbit