Repository navigation
ref(toxgen): Remove unused get_file_hash() and get_last_updated() helpers - #8173
Merged
alexander-alderman-webb merged 1 commit intoNov 3, 2026
Merged
Conversation
Contributor
Coverage Results 📊✅ 136856 passed | ⏭️ 7456 skipped | Total: 144312 | Pass Rate: 94.83% | Execution Time: 461m 24s 📊 Comparison with Base Branch
➖ Removed Tests (1)View removed tests
All tests are passing successfully. ✅ Patch coverage is 100.00% (no changed executable lines found; target 80%). Coverage diff@@ Coverage Diff @@
## master #8173 +/-##
==========================================
Coverage 90.32% 90.32% —%
==========================================
Files 203 203 —
Tracked lines 26872 26872 —
Branches 10044 10044 —
==========================================
Hits 24272 24272 —
Misses 2600 2600 —
Partials 1520 1520 —Generated by Coverage Action |
alexander-alderman-webb
approved these changes
Nov 3, 2026
get_file_hash() and get_last_updated() helpers
alexander-alderman-webb
deleted the
ref/toxgen-remove-unused-hash-helpers
branch
November 3, 2026 08:18
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Removes
get_file_hash()andget_last_updated()fromscripts/populate_tox/populate_tox.py. Nothing has called either of them for about a year.#4072 (Feb 2025) added both for toxgen's
--fail-on-changesmode.get_last_updated()read the last commit timestamp oftox.ini, so new releases after that point could be ignored.get_file_hash()hashedtox.inibefore and after regeneration to spot manual edits. #4892 (Oct 2025, "Remove toxgen check") droppedfail_on_changesand removed every call to both helpers, but left the definitions behind.Evidence
git grep -w get_file_hashandgit grep -w get_last_updatedacross the whole repo match only the definitions.git log -Sshows only tests: Addfail_on_changesto toxgen #4072 (added) and ci: Remove toxgen check #4892 (callers removed).populate_tox.py.Why it's safe
scripts/. It isn't part of the publishedsentry_sdkpackage, so SDK users aren't affected.hashlib,subprocess,Path,Optional,datetime) are still used elsewhere in the script.timezoneis still covered by the existing# noqa: F401that keeps the commented-outCUTOFFexample working.scripts/generate-test-files.sh --only bottlestill runs to completion. Its regeneratedtox.iniand release caches only picked up new upstream releases, so I didn't commit them.Issues
n/a
via automation
sched_65eed06cc199036c2b13411096f412d4· Run IDsched_65eed06cc199036c2b13411096f412d4:1793606400000.--
View Session [Sentry]