Repository navigation
feat(trace-view): Find the previous trace from its span link (not attribute) - #126702
Merged
Merged
Conversation
github-actions
Bot
added
the
Scope: Frontend
Member
Author
|
bugbot run |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 37a4894. Configure here.
Lms24
approved these changes
Oct 8, 2026
Comment on lines
+11
to
+15
| /** | ||
| * Fallback for spans without a `previous_trace` link (e.g. from older SDKs). Format: | ||
| * `[traceId]-[spanId]-[sampledFlag]`. A malformed value disables the query or finds nothing. | ||
| */ | ||
| function parsePreviousTraceAttribute( |
Member
There was a problem hiding this comment.
l: not fully sure if we need this. In JS We sent links even before we sent the attribute. But unless we want to minimize bundle size, it's fine to keep this around.
Member
Author
There was a problem hiding this comment.
it's not a lot of lines but true, good catch. We can remove this so also no future SDKs are implementing based on this feature.
Member
Author
|
Since this PR was mentioned in PR #126894, I fixed this in |
s1gr1d
enabled auto-merge (squash)
October 9, 2026 12:34
s1gr1d
added a commit
to getsentry/sentry-javascript
that referenced
this pull request
Oct 19, 2026
Small comment change related to this change in Sentry: getsentry/sentry#126702
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since #125741 we can filter
sentry.links, which lets us improve "Previous trace". SDKs send theprevious_tracelink together with thesentry.previous_traceattribute.previous_tracelink instead of the attribute.sentry.links, but only with a wildcard on private JSON, which cannot filter by link type or sampling. Removing the attribute needs links as EAP objects.