Repository navigation
cmd/dlv, pkg/proc: use T.TempDir in tests for temp dirs - #3256
Merged
Merged
Conversation
alexandear
force-pushed
the
cmd-dlv-t-temp-dir
branch
from
January 24, 2023 20:11
f68d766 to
effe983
Compare
alexandear
changed the title
alexandear
marked this pull request as ready for review
January 24, 2023 20:18
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR simplifies tests in
cmd/dlvandpkg/procby replacing usages ofioutil.TempDirwitht.TempDir.T.TempDirautomatically removes the temporary directory at the end of a test. So, no need to manually calldefer os.RemoveAll(tmpDir)