Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
applyGainMapaccepts RGB888 base images, butisPixelFormatRgbomits the format. RGB samples therefore go through a YUV-to-RGB conversion, causing a strong color cast even at unity display boost.Normal API decoding does not currently reach this case: HDR reconstruction uses YCbCr or RGBA base images. Direct callers, including component tests and custom integrations, can get incorrect output even though the call succeeds. This change makes that accepted input work correctly and adds a one-pixel regression that checks neutral gray against its expected linear half-float value.
Validation: the regression fails before the fix and passes afterward. Local Release testing passes 1,104 tests with 224 existing skips; focused AddressSanitizer and UndefinedBehaviorSanitizer checks also pass.