Skip to content

disable-chmodSync-on-windows #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
grant merged 1 commit into from
Nov 25, 2018
Merged

disable-chmodSync-on-windows #7

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,8 +33,11 @@ module.exports = (dirname, name) => {
write: (obj) => new Promise((resolve, reject) => {
jsonfile.writeFile(fullpath, obj, (err) => {
if (err) return reject(err);
// same as chmod 600
fs.chmodSync(fullpath, fs.constants.S_IRUSR | fs.constants.S_IWUSR);
// if a platform is not Windows(include x64)
if ('win32' !== process.platform) {
// same as chmod 600
fs.chmodSync(fullpath, fs.constants.S_IRUSR | fs.constants.S_IWUSR);
}
resolve(obj);
});
}),
Expand Down
23 changes: 13 additions & 10 deletions test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,16 +15,19 @@ test('write', async (t) => {
const writeGlobal = await dotglobal.write({a: 1});
const writeLocal = await dotlocal.write({a: 1});

// If file permission is incorrect,
// {{file permission value} logical AND {777 in octal}}
// !== {correct permission value}.
if ((fs.statSync(dotglobalfullpath).mode & 0o777) !== (fs.constants.S_IRUSR
| fs.constants.S_IWUSR)) {
t.fail();
}
if ((fs.statSync(dotlocalfullpath).mode & 0o777) !== (fs.constants.S_IRUSR
| fs.constants.S_IWUSR)) {
t.fail();
// if a platform is not Windows(include x64)
if ('win32' !== process.platform) {
// If file permission is incorrect,
// {{file permission value} logical AND {777 in octal}}
// !== {correct permission value}.
if ((fs.statSync(dotglobalfullpath).mode & 0o777) !== (fs.constants.S_IRUSR
| fs.constants.S_IWUSR)) {
t.fail();
}
if ((fs.statSync(dotlocalfullpath).mode & 0o777) !== (fs.constants.S_IRUSR
| fs.constants.S_IWUSR)) {
t.fail();
}
}
t.pass();
await dotglobal.delete();
Expand Down