Skip to content
This repository was archived by the owner on Sep 20, 2021. It is now read-only.
This repository was archived by the owner on Sep 20, 2021. It is now read-only.

Remove $nodeId from Token rule definition. #86

Open
Open
Remove $nodeId from Token rule definition.#86

Description

@SerafimArts
SerafimArts
opened on Aug 15, 2018

The third argument to the Token rule is not needed and is not required at runtime or for some other things. We can get rid of it.

new Token($id, $name, $nodeId, $unificationId, $kept);
//                    ^^^^^^^ - excess

Activity

  1. flip111 commented on Jan 25, 2019

    @flip111
    flip111
    on Jan 25, 2019

    I read the code, and right now, I found no useful case where the $nodeId is used in the constructor. It is always set to null. I guess we can remove it!

    #85 (comment)

    Should be easy to fix this. Suggest adding issues to

    https://up-for-grabs.net/#/

    https://github.com/MunGell/awesome-for-beginners#php

    https://www.firsttimersonly.com/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions