Repository navigation
feat(tui): add a TOTAL row with totals and portfolio history chart - #126
Open
ivysotskyi wants to merge 3 commits into
Open
ivysotskyi wants to merge 3 commits into
ivysotskyi wants to merge 3 commits into
Conversation
Owner
|
Could you check this spec for how commit message should be structured (https://www.conventionalcommits.org/en/v1.0.0/#specification), or just check commit history. thanks! |
The separate Total line only showed market value. Move it into the table as a bold TOTAL row that stays at the bottom when sorting, and add total cost, daily change (absolute and %) and unrealized P&L, all in the base currency. Signed-off-by: Ivan Vysotskyi <ivan.vysotskyy@gmail.com>
There was no way to see how the portfolio as a whole moved over time. Pressing g on the TOTAL row now charts what the current holdings were worth each day over 1M to 5Y, against a cost-basis line, with a summary of change, high, low and max drawdown. Signed-off-by: Ivan Vysotskyi <ivan.vysotskyy@gmail.com>
ivysotskyi
force-pushed
the
feature/totals-in-separate-row
branch
from
November 11, 2026 19:16
9ae02e4 to
7cf5abd
Compare
ivysotskyi
changed the title
Author
done and force-pushed |
igoropaniuk
self-requested a review
November 12, 2026 15:09
Owner
|
@ivysotskyi thanks! It seems that CI is still failing :( You can ensure that all tests are passing successfully by running |
Signed-off-by: Ivan Vysotskyi <ivan.vysotskyy@gmail.com>
ivysotskyi
force-pushed
the
feature/totals-in-separate-row
branch
from
November 12, 2026 23:55
2e2f502 to
1cf851c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds portfolio-level totals to the dashboard and a chart of how the
portfolio's value moved over time.