Skip to content

Reproduce graphs from original data #8

Open

Description

@krlmlr

Done by inst/getdata.R, I have trouble recreating yeast and USairports .

  • The Nature publications required for yeast are not found, cannot open URL 'https://www.nature.com/nature/journal/v417/n6887/extref/nature750-s1.doc': HTTP status was '404 Not Found', new location linked at https://www.nature.com/articles/nature750#Sec8
  • USairports relies on ~/Downloads/1067890998_T_T100D_SEGMENT_ALL_CARRIER.csv

@gaborcsardi: Can you help with the .csv file?

Moving forward, I propose to separate the downloads from the creation of the graphs so that we're less reliant on external data storage here.

Activity

  1. gaborcsardi commented on Jun 16, 2023

    @gaborcsardi
    Contributor

    I don't have that CSV any more, sorry.

  2. krlmlr commented on Jun 16, 2023

    @krlmlr
    ContributorAuthor

    Thanks. We could create that CSV from the graph, I suppose.

    I'm thrilled that the other graphs seem to be recreatable without problems. We'll need to compare the results, though.

  3. szhorvat commented on Jun 16, 2023

    @szhorvat
    Member

    Just to understand, is it necessary to recreate the networks from the original source or are you just testing the scripts that do so?

  4. krlmlr commented on Jun 17, 2023

    @krlmlr
    ContributorAuthor

    No, it's not necessary, just good practice.

  5. maelle commented on Jun 19, 2023

    @maelle
    Contributor

    @krlmlr

    Moving forward, I propose to separate the downloads from the creation of the graphs so that we're less reliant on external data storage here.

    Do you mean the package should contain a copy of the datasets? Or we store them somewhere else?

  6. krlmlr commented on Jun 19, 2023

    @krlmlr
    ContributorAuthor

    I don't mind a copy of the raw data on GitHub.

  7. maelle commented on Jun 19, 2023

    @maelle
    Contributor

    so the task is to try and locate the yeast and airport data?

    how do we compare the obtained graphs?

  8. maelle commented on Jun 19, 2023

    @maelle
    Contributor

    reg the yeast data, it probably is in https://www.nature.com/articles/nature750 but I don't have access (and even if we get access I suppose the data isn't really free to share 😅 )

  9. krlmlr commented on Jun 19, 2023

    @krlmlr
    ContributorAuthor

    Yes, yeast seems solved. The only tricky challenge is to reverse-engineer the CSV file, but I'm not sure it's worth it.

  10. maelle commented on Jun 19, 2023

    @maelle
    Contributor

    so what are the TODOs?

  11. krlmlr commented on Jun 19, 2023

    @krlmlr
    ContributorAuthor
    • Find a place for the raw files in this repo
    • Split the getdata.R script, perhaps one unified download script, and one script per dataset?
    • Make sure that the generated data is unchanged
  12. maelle commented on Jun 19, 2023

    @maelle
    Contributor

    Wait so we need 3 new issues, this issue is not really closed then?

  13. reopened this on Jun 19, 2023
  14. krlmlr commented on Jun 19, 2023

    @krlmlr
    ContributorAuthor

    One issue is fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions