Repository navigation
cgroup collection html output by container is missing - #719
Merged
Merged
Conversation
…rics_html_cgroup_breakout
…rics_html_cgroup_breakout
adgubrud
force-pushed
the
metrics_html_cgroup_breakout
branch
from
October 16, 2026 16:46
0ebe753 to
40e4aac
Compare
…rics_html_cgroup_breakout
Removes the code changes merged in intel#720 from this branch: - the "pmu enumeration safety" probe script and the perfEnumerationFaultsKernel predicate in cmd/metrics/metadata.go - the sysfs-based event enumeration scripts that replaced 'perf list --json' on affected targets - the enumerateEventsFromSysfs parameter on getMetadataScripts and its use from the x86 and ARM metadata collectors - cmd/metrics/metadata_pmu_safety_test.go - the 'perf list tracepoint' change in the telemetry syscall enumeration script The go.mod/go.sum excelize and mscfb bumps that intel#720 also carried are intentionally left in place: main has since moved excelize forward again in intel#731, and reverting them here would downgrade a patched dependency. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
govulncheck fails the build on GO-2026-6809, "Distrust compromised intermediate certificates in crypto/x509", found in crypto/x509@go1.27.2 and fixed in go1.27.3. It is reachable from util.CopyFile via io.Copy, so it lands in the Symbol Results that make check_vuln gates on. - builder/build.Dockerfile: golang:1.27.2 -> golang:1.27.3, digest updated to the 1.27.3 image index - tools/build.Dockerfile: GO_VERSION 1.27.2 -> 1.27.3, so the Go tools embedded in the release package are built with the patched stdlib too Verified by running govulncheck inside golang:1.27.3 against this tree: "No vulnerabilities found" in the symbol results, where go1.27.2 reported one. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Clears five HTTP/2 advisories govulncheck reports against golang.org/x/net@v0.59.0 (GO-2026-6603, 6610, 6611, 6612, 6617), all fixed in v0.60.0. None are called by PerfSpect, so they were reported at module level only and did not fail the build. v0.60.0 rather than the newer v0.61.0: its own requirements are all at or below what the module graph already selects, so nothing else moves. The one module-level advisory left is GO-2026-5932 on golang.org/x/crypto/openpgp, which has no fixed version. x/crypto is pulled in by excelize for crypto/md4; openpgp is never imported. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This reverts commit fc62700, restoring the code from intel#720 on this branch: - the "pmu enumeration safety" probe and perfEnumerationFaultsKernel predicate in cmd/metrics/metadata.go - the sysfs event enumeration scripts and the enumerateEventsFromSysfs parameter on getMetadataScripts, with its x86 and ARM call sites - cmd/metrics/metadata_pmu_safety_test.go - 'perf list tracepoint' in the telemetry syscall enumeration script The affected paths are now byte-identical to 40ab066, the state before the revert. go.mod and go.sum are untouched, as fc62700 deliberately left the excelize and mscfb versions alone. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Feature implementation to address Issue #718