Skip to content

docs: distinguish authorization rule matching from allowing - #3797

Open
git-jxj wants to merge 1 commit into
istio:masterfrom
git-jxj:docs/authz-rule-matching
Open

git-jxj wants to merge 1 commit into
istio:masterfrom
git-jxj:docs/authz-rule-matching

Conversation

@git-jxj

@git-jxj git-jxj commented Oct 2, 2026

Copy link
Copy Markdown
Member

The AuthorizationPolicy reference describes omitted matching fields as allowing requests, which is misleading for DENY policies. Describe matching consistently in Rule, Source, Operation, and Condition, and clarify that omitted rule fields impose no additional matching requirement.

Regenerate the API reference and Go comments. No policy behavior or validation changes.

Fixes #2071.

Validation: make gen, buf lint, make test, and generated HTML checks. The documentation check fails on the original reference and passes after regeneration.

@git-jxj
git-jxj requested a review from a team as a code owner October 2, 2026 08:42
@istio-policy-bot

Copy link
Copy Markdown

🤔 🐛 You appear to be fixing a bug in Go code, yet your PR doesn't include updates to any test files. Did you forget to add a test?

Courtesy of your friendly test nag.

@istio-policy-bot

Copy link
Copy Markdown

😊 Welcome @git-jxj! This is either your first contribution to the Istio api repo, or it's been
a while since you've been here.

You can learn more about the Istio working groups, Code of Conduct, and contribution guidelines
by referring to Contributing to Istio.

Thanks for contributing!

Courtesy of your friendly welcome wagon.

@istio-testing istio-testing added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. needs-ok-to-test labels Oct 2, 2026
@istio-testing

Copy link
Copy Markdown
Collaborator

Hi @git-jxj. Thanks for your PR.

I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Tip

We noticed you've done this a few times! Consider joining the org to skip this step and gain /lgtm and other bot rights. We recommend asking approvers on your previous PRs to sponsor you.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

1 similar comment
@istio-testing

Copy link
Copy Markdown
Collaborator

Hi @git-jxj. Thanks for your PR.

I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Tip

We noticed you've done this a few times! Consider joining the org to skip this step and gain /lgtm and other bot rights. We recommend asking approvers on your previous PRs to sponsor you.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kfaseela

kfaseela commented Oct 2, 2026

Copy link
Copy Markdown
Member

@git-jxj you can add yourself as an Istio member, now that you have made many contributions. Then you don't have to wait another member to do /ok-to-test on your PR

@git-jxj

git-jxj commented Oct 2, 2026

Copy link
Copy Markdown
Member Author

Thanks for the encouragement, @kfaseela! I'd be very happy to join the Istio organization as a member and continue contributing. I'll follow the membership guidelines and open a PR in istio/community to add myself to org/members.yaml. Thanks for your support!

@git-jxj git-jxj mentioned this pull request Oct 2, 2026
6 tasks done
@git-jxj

git-jxj commented Oct 15, 2026

Copy link
Copy Markdown
Member Author

/ok-to-test

@istio-testing istio-testing added ok-to-test Set this label allow normal testing to take place for a PR not submitted by an Istio org member. and removed needs-ok-to-test labels Oct 15, 2026
@istio-testing

Copy link
Copy Markdown
Collaborator

@git-jxj: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
build_api 9c3b820 link true /test build
Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@git-jxj

git-jxj commented Oct 15, 2026

Copy link
Copy Markdown
Member Author

The newly authorized build_api run for 9c3b8207890b fails in golangci-lint while importing Go standard-library export data: version 5 is greater than maximum supported version 4. The unrelated #3808 run has the same failure. gencheck_api and release-notes_api pass.

This appears to be a CI toolchain/importer compatibility issue. Could a maintainer check the build-tools versions? I will keep this documentation change scoped and wait for the CI fix before retrying the failed job.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ok-to-test Set this label allow normal testing to take place for a PR not submitted by an Istio org member. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Doc.: Incorrect "allowed" instead of "matches" in Rule documentation

4 participants