Repository navigation
Conversation
|
🤔 🐛 You appear to be fixing a bug in Go code, yet your PR doesn't include updates to any test files. Did you forget to add a test? Courtesy of your friendly test nag. |
|
😊 Welcome @git-jxj! This is either your first contribution to the Istio api repo, or it's been You can learn more about the Istio working groups, Code of Conduct, and contribution guidelines Thanks for contributing! Courtesy of your friendly welcome wagon. |
|
Hi @git-jxj. Thanks for your PR. I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with Tip We noticed you've done this a few times! Consider joining the org to skip this step and gain Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
1 similar comment
|
Hi @git-jxj. Thanks for your PR. I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with Tip We noticed you've done this a few times! Consider joining the org to skip this step and gain Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@git-jxj you can add yourself as an Istio member, now that you have made many contributions. Then you don't have to wait another member to do /ok-to-test on your PR |
|
Thanks for the encouragement, @kfaseela! I'd be very happy to join the Istio organization as a member and continue contributing. I'll follow the membership guidelines and open a PR in istio/community to add myself to org/members.yaml. Thanks for your support! |
|
/ok-to-test |
|
@git-jxj: The following test failed, say
DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
The newly authorized build_api run for This appears to be a CI toolchain/importer compatibility issue. Could a maintainer check the build-tools versions? I will keep this documentation change scoped and wait for the CI fix before retrying the failed job. |
The AuthorizationPolicy reference describes omitted matching fields as allowing requests, which is misleading for DENY policies. Describe matching consistently in Rule, Source, Operation, and Condition, and clarify that omitted rule fields impose no additional matching requirement.
Regenerate the API reference and Go comments. No policy behavior or validation changes.
Fixes #2071.
Validation:
make gen,buf lint,make test, and generated HTML checks. The documentation check fails on the original reference and passes after regeneration.