Skip to content

Allow 63-character WorkloadEntry port names - #3799

Open
git-jxj wants to merge 1 commit into
istio:masterfrom
git-jxj:fix/workload-port-name-length
Open

git-jxj wants to merge 1 commit into
istio:masterfrom
git-jxj:fix/workload-port-name-length

Conversation

@git-jxj

@git-jxj git-jxj commented Oct 2, 2026

Copy link
Copy Markdown
Member

The WorkloadEntry port-map CEL rule rejects names of exactly 63 characters, although Istio's existing port-name validation allows them. The same rule is embedded in ServiceEntry endpoints and WorkloadGroup templates.

Allow the 63-character boundary, regenerate all CRD versions, and add positive 62/63-character and negative 64-character cases for all three resource locations. Includes a release note.

Validation: make gen, buf lint, make lint, and make test passed; the final fixture update also passed the complete CRD test suite. Cross-version validation and server-side admission checks on Kubernetes v1.33.8 confirm that 62/63 characters are accepted and 64 are rejected. The server checks used an isolated temporary API group with the generated schemas.

@git-jxj
git-jxj requested a review from a team as a code owner October 2, 2026 11:01
@istio-testing istio-testing added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. needs-ok-to-test labels Oct 2, 2026
@istio-testing

Copy link
Copy Markdown
Collaborator

Hi @git-jxj. Thanks for your PR.

I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Tip

We noticed you've done this a few times! Consider joining the org to skip this step and gain /lgtm and other bot rights. We recommend asking approvers on your previous PRs to sponsor you.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

1 similar comment
@istio-testing

Copy link
Copy Markdown
Collaborator

Hi @git-jxj. Thanks for your PR.

I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Tip

We noticed you've done this a few times! Consider joining the org to skip this step and gain /lgtm and other bot rights. We recommend asking approvers on your previous PRs to sponsor you.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ramaraochavali

Copy link
Copy Markdown
Contributor

/ok-to-test

@istio-testing istio-testing added ok-to-test Set this label allow normal testing to take place for a PR not submitted by an Istio org member. and removed needs-ok-to-test labels Oct 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ok-to-test Set this label allow normal testing to take place for a PR not submitted by an Istio org member. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants