Repository navigation
Conversation
PortTrafficPolicy had no retryBudget field, and a destination-level budget is not inherited by ports with port-level settings, so those ports could not have a retry budget at all.
|
😊 Welcome @star3058! This is either your first contribution to the Istio api repo, or it's been You can learn more about the Istio working groups, Code of Conduct, and contribution guidelines Thanks for contributing! Courtesy of your friendly welcome wagon. |
|
Hi @star3058. Thanks for your PR. I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
1 similar comment
|
Hi @star3058. Thanks for your PR. I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
ericdbishop
left a comment
There was a problem hiding this comment.
Commented on main PR: istio/istio#62500 (review)
Part of istio/istio#62499
Adds
retryBudgettoPortTrafficPolicy. A destination-levelretryBudgetis not inherited by ports withportLevelSettings, so those ports currently cannot have a retry budget. The new field follows the same rule as the other port-level fields.Implementation: istio/istio#62500