Skip to content

networking: add retryBudget to DestinationRule portLevelSettings - #3818

Open
star3058 wants to merge 3 commits into
istio:masterfrom
star3058:port-level-retry-budget
Open

star3058 wants to merge 3 commits into
istio:masterfrom
star3058:port-level-retry-budget

Conversation

@star3058

@star3058 star3058 commented Oct 29, 2026 •

Copy link
Copy Markdown

Part of istio/istio#62499

Adds retryBudget to PortTrafficPolicy. A destination-level retryBudget is not inherited by ports with portLevelSettings, so those ports currently cannot have a retry budget. The new field follows the same rule as the other port-level fields.

Implementation: istio/istio#62500

PortTrafficPolicy had no retryBudget field, and a destination-level
budget is not inherited by ports with port-level settings, so those
ports could not have a retry budget at all.
@star3058
star3058 requested a review from a team as a code owner October 29, 2026 08:58
@istio-policy-bot

Copy link
Copy Markdown

😊 Welcome @star3058! This is either your first contribution to the Istio api repo, or it's been
a while since you've been here.

You can learn more about the Istio working groups, Code of Conduct, and contribution guidelines
by referring to Contributing to Istio.

Thanks for contributing!

Courtesy of your friendly welcome wagon.

@istio-testing istio-testing added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. needs-ok-to-test labels Oct 29, 2026
@istio-testing

Copy link
Copy Markdown
Collaborator

Hi @star3058. Thanks for your PR.

I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

1 similar comment
@istio-testing

Copy link
Copy Markdown
Collaborator

Hi @star3058. Thanks for your PR.

I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ericdbishop ericdbishop left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commented on main PR: istio/istio#62500 (review)

@star3058
star3058 requested a review from ericdbishop November 4, 2026 00:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-ok-to-test size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants