Skip to content

Updated fork for python-3 compatibility. - #99

Merged
jamesls merged 2 commits into
jmespath:masterfrom
springcomp:feature/tooling
May 25, 2022
Merged

jamesls merged 2 commits into
jmespath:masterfrom
springcomp:feature/tooling

Conversation

@springcomp

Copy link
Copy Markdown
Contributor

Fixes:

#95

@springcomp springcomp mentioned this pull request May 25, 2022
Sphinx needed an upgrade in order to build on py3.
Also upgraded the other dependencies to modern versions
so we pull in the latest bugfixes.

@jamesls jamesls left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I had to bump the version of Sphinx in the requirements.txt file otherwise I was getting this error on py3.9:

$ make html
/Library/Developer/CommandLineTools/usr/bin/make -C docs/ html
sphinx-build -b html -d _build/doctrees   . _build/html
Running Sphinx v1.2.2
loading pickled environment... failed: env version not current

Exception occurred:
  File "/Users/jamessar/.virtualenvs/tmp-d018bd311cd3cc8/lib/python3.9/site-packages/sphinx/jinja2glue.py", line 15, in <module>
    from jinja2 import FileSystemLoader, BaseLoader, TemplateNotFound, \
ImportError: cannot import name 'contextfunction' from 'jinja2'

Also went ahead and bumped the other packages to more recent versions so we pull in the latest bug fixes.

@jamesls
jamesls merged commit 7840dd5 into jmespath:master May 25, 2022
@springcomp
springcomp deleted the feature/tooling branch May 25, 2022 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants