Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
heaplessfeature promises allocation-free formatting during serialization, but the serializers only select their existing stack-buffer path when the legacyser_as_strfeature is enabled. Withheaplessalone they callSerializer::collect_str, whose default implementation allocates aString.Select the existing buffer path for either feature. This covers
Ipv4Net,Ipv6Netand theirIpNetwrapper while preserving binary serialization and the legacy feature. Fixes #73.The regression measures allocations while a nonallocating
serde_testserializer checks the exact emitted strings, including maximum-width addresses. On the original source,heaplessalone records allocations and fails; the legacyserde,ser_as_strcontrol passes with zero allocations.With the fix,
cargo test --features heapless,cargo test --features serde,ser_as_str,cargo test --all-features, andcargo test --no-default-features --features heaplesseach pass 37 unit tests, the allocation regression and 56 doctests.cargo clippy --all-features --all-targets, focused test formatting andgit diff --checkpass. Clippy reports existing source warnings, also present on a clean-master control. These checks establish allocation-free formatting with the test serializer; other serializers may allocate themselves.