Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
::must represent at least one zero group, but the IPv6 parser currently allows eight explicit groups in addition to the compression marker. Reserve that group when reading the suffix, including when an embedded IPv4 address supplies the final two groups.Fixes #50.
The regressions compare
Ipv6NetandIpNetagainststd::net::Ipv6Addrwith every compression position, boundary group counts, and prefixes 0/64/128. They also cover embedded IPv4 tails and human-readable Serde deserialization. All three fail on unchanged master and pass with the fix.Validation:
cargo test --all-features(37 unit tests, 3 regressions, 56 doctests), default/no-default-feature tests, all-feature release tests, build and docs pass. Clippy completes with the same existing warnings as clean master. The new test file passes rustfmt; repository-wide formatting still fails on existing formatting differences also present on clean master.