Repository navigation
test(api): avoid redundant Sandbox calls in Jinja2 tests - #46851
Merged
Merged
Conversation
Contributor
Pyrefly Type Coverage
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #46851 +/- ##
=======================================
Coverage 90.29% 90.29%
=======================================
Files 6463 6463
Lines 408190 408190
Branches 81856 81856
=======================================
+ Hits 368569 368575 +6
+ Misses 33213 33207 -6
Partials 6408 6408
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
hyoban
marked this pull request as ready for review
November 20, 2026 11:45
lyzno1
approved these changes
Nov 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The API integration job for #46221 failed in
TestJinja2CodeExecutor.test_jinja2. Sandbox returned HTTP 200 witherror: timeoutandsignal: killedbefore the stdout assertion. The same test passed in the PR #46847 rerun. Two earlier queue entries hit the same Sandbox timeout in a different Jinja2 case, whose coverage moved to unit tests in #46694. Failure log · Passing integration jobCheck variable substitution and the exact stdout framing through the production-generated runner in the existing unit suite. Move the runner placeholder assertions there as well. The integration file retains the workflow template case, which sends a real Sandbox request and checks the parsed result.
Verification
nice -n 10in four parallel lanes, five runs each. The baseline had 0 failures in 20 runs of seven tests. The updated file had 0 failures in 20 runs of eight tests.git diff --checkpassed. The integration baseline comes from CI, and the remaining Sandbox request is exercised by the API integration job.autofix-cicancelled attempt 1. The four failed summary jobs reported that their dependencies were cancelled, and attempt 2 passed on the same SHA. Cancelled attemptScreenshots
Backend test coverage change.
Checklist
make lint && make type-check(backend) andvp staged(frontend) to appease the lint gods