[keelerm84]

Summary

FlagBuilder.ValueForAll in ldtestdata and ldtestdatav2 replaced the flag's variations with the single value and called VariationForAllIndex(0), which leaves the off variation unchanged. A new test flag is a boolean flag with off variation 1, so the built flag had variations: [value] and offVariation: 1. That index is out of range, so the flag failed to evaluate (malformed flag) when targeting was off. The method is documented to return the value whether targeting is on or off.

ValueForAll now also sets the off variation to 0. VariationForAll and VariationForAllIndex are unchanged; they still leave the off variation alone, as documented.

The new test builds a flag with ValueForAll, evaluates it with targeting on and off, and checks that both return the value.

This matches the Ruby fix in launchdarkly/ruby-server-sdk#489.

_{Opened from termag}

---

Note

Overview
Fixes FlagBuilder.ValueForAll in ldtestdata and ldtestdatav2 so built test flags match their docs: the same value is returned whether targeting is on or off.

Previously the helper collapsed the flag to a single variation and set fallthrough to index 0, but left the default off variation at index 1 from the initial boolean setup. With only one variation, evaluation failed when targeting was off. ValueForAll now also sets OffVariationIndex(0); VariationForAll / VariationForAllIndex behavior is unchanged.

Adds TestValueForAllReturnsValueWhetherTargetingIsOnOrOff in both packages (evaluator checks for on=true and on=false).

^{Reviewed by Cursor Bugbot for commit e41d77d. Bugbot is set up for automated code reviews on this repo. Configure here.}