Skip to content

fix: update install-hooks target to use pre-commit install - #731

Merged
ffantl-ld merged 1 commit into
mainfrom
devin/1782851457-fix-install-hooks
Jun 30, 2026
Merged

ffantl-ld merged 1 commit into
mainfrom
devin/1782851457-fix-install-hooks

Conversation

@ffantl-ld

@ffantl-ld ffantl-ld commented Jun 30, 2026 •

Copy link
Copy Markdown
Contributor

Requirements

  • I have added test coverage for new or changed functionality
  • I have followed the repository's pull request submission guidelines
  • I have validated my changes against all supported platform versions

Related issues

N/A

Describe the solution you've provided

The install-hooks Makefile target was broken — it referenced git/hooks/* which was removed in a previous commit. The repo now uses the pre-commit framework (.pre-commit-config.yaml), so the target is updated to run pre-commit install.

How to test it

Run make install-hooks — it should succeed and install the pre-commit hook.

Describe alternatives you've considered

Could recreate the old git/hooks/ directory, but the repo has already migrated to the pre-commit framework so this aligns with that.

Additional context

None.

Link to Devin session: https://app.devin.ai/sessions/a88b0e232de74902a54218c38843a6b2
Requested by: @ffantl-ld


Note

Low Risk
Makefile-only change for local dev hook setup; no runtime or CI behavior change beyond fixing a broken target.

Overview
Fixes broken make install-hooks by replacing the removed git/hooks/* copy step with pre-commit install, matching the repo’s .pre-commit-config.yaml setup.

Contributors running make install-hooks (documented in CONTRIBUTING.md and AGENTS.md) get working git hooks again instead of a failing Makefile target.

Reviewed by Cursor Bugbot for commit 04154c1. Bugbot is set up for automated code reviews on this repo. Configure here.

Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
@ffantl-ld ffantl-ld self-assigned this Jun 30, 2026
@devin-ai-integration

Copy link
Copy Markdown
Contributor

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment, CI, and merge conflict monitoring

@ffantl-ld
ffantl-ld merged commit 424147f into main Jun 30, 2026
9 checks passed
@ffantl-ld
ffantl-ld deleted the devin/1782851457-fix-install-hooks branch June 30, 2026 22:00
social4hyq pushed a commit to social4hyq/homebrew-core that referenced this pull request Sep 20, 2026
ldcli 3.1.0

Created-by: HarmonybrewBot
Commit-by: HarmonybrewBot
Merged-by: HarmonybrewBot
Description: Created by `brew bump`

---

Created with `brew bump-formula-pr`.<details>
  <summary>release notes</summary>
  <pre>## [3.1.0](launchdarkly/ldcli@v3.0.4...v3.1.0) (2026-07-10)


### Features

* [FD-5561] implement FDv2 polling endpoint GET /sdk/poll ([#701](launchdarkly/ldcli#701)) ([8a1cda1](launchdarkly/ldcli@8a1cda1))
* [FD-5562] Adding FDv2 Stream endpoint support in the dev server ([#703](launchdarkly/ldcli#703)) ([ff8c116](launchdarkly/ldcli@ff8c116))
* add whoami command ([#657](launchdarkly/ldcli#657)) ([d2cca65](launchdarkly/ldcli@d2cca65))
* support React Native sourcemaps in sourcemaps upload ([#735](launchdarkly/ldcli#735)) ([e41a87f](launchdarkly/ldcli@e41a87f))


### Bug Fixes

* prevent subcommands from showing root-level commands in help output ([#730](launchdarkly/ldcli#730)) ([ca49101](launchdarkly/ldcli@ca49101))
* **REL-13522:** convert kebab-case query params to camelCase ([#705](launchdarkly/ldcli#705)) ([98700e4](launchdarkly/ldcli@98700e4))
* update install-hooks target to use pre-commit install ([#731](launchdarkly/ldcli#731)) ([424147f](launchdarkly/ldcli@424147f))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

<!-- CURSOR_SUMMARY --></pre>
  <p>View the full release notes at <a href="https://github.com/launchdarkly/ldcli/releases/tag/v3.1.0">https://github.com/launchdarkly/ldcli/releases/tag/v3.1.0</a>.</p>
</details>
<hr>

See merge request: Harmonybrew/homebrew-core!14012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants