Skip to content

fix: Add local flag overrides using dev server (#837) - #850

Merged
davidbrackbill merged 1 commit into
mainfrom
db/revert-local-flag-overrides
Oct 5, 2026
Merged

davidbrackbill merged 1 commit into
mainfrom
db/revert-local-flag-overrides

Conversation

@davidbrackbill

@davidbrackbill davidbrackbill commented Oct 5, 2026 •

Copy link
Copy Markdown
Contributor

Reverts #837 as the feature has a UI bug and I don't want to block CLI releases.

Claude claude@anthropic.com

@davidbrackbill
davidbrackbill marked this pull request as ready for review October 5, 2026 20:43
@davidbrackbill
davidbrackbill requested a review from a team as a code owner October 5, 2026 20:43
@davidbrackbill davidbrackbill changed the title Revert: Add local flag overrides using dev server (#837) fix: Add local flag overrides using dev server (#837) Oct 5, 2026
@davidbrackbill
davidbrackbill merged commit 9197f92 into main Oct 5, 2026
7 of 12 checks passed
@davidbrackbill
davidbrackbill deleted the db/revert-local-flag-overrides branch October 5, 2026 21:00
nieblara added a commit that referenced this pull request Oct 28, 2026
…t fix (#851)

* Revert "fix: Add local flag overrides using dev server (#837) (#850)"

This reverts commit 9197f92.

* fix: reset the override and local flag filters when they no longer apply

The filter state stayed set after the last override went away. A new
override then turned the filter on again and hid other flags. Two
effects now reset each filter when its condition is false.

Add tests for both filters.

Co-authored-by: Ramon Niebla <nieblara@users.noreply.github.com>

---------

Co-authored-by: Cursor Agent <cursoragent@cursor.com>
Co-authored-by: Ramon Niebla <nieblara@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants