Skip to content

feat: Add preconfigured flags and event settings to TestDataV2 #486

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
keelerm84 wants to merge 8 commits into
base: feat/9.x
Choose a base branch
from
Open

feat: Add preconfigured flags and event settings to TestDataV2 #486

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
0627ceb
feat!: Remove payload filter support from the FDv2 data system
keelerm84 Nov 5, 2026
9876aae
feat: Add preconfigured flags and event settings to TestDataV2
keelerm84 Nov 5, 2026
d9979ff
test: Run the client specs on the FDv2 data system
keelerm84 Nov 5, 2026
f469ba3
Merge remote-tracking branch 'origin/feat/9.x' into mk/SDK-3471/specs…
keelerm84 Nov 5, 2026
f4887c4
fix: Validate preconfigured TestDataV2 items and deliver changes in o…
keelerm84 Nov 5, 2026
aadae60
fix: Reject preconfigured TestDataV2 values that are not JSON values
keelerm84 Nov 5, 2026
c0f0460
fix: Keep TestDataV2 flags unchanged when a rule builder changes afte…
keelerm84 Nov 5, 2026
c638040
fix: Prevent TestDataV2 from briefly restoring an older flag when a c…
keelerm84 Nov 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
116 changes: 61 additions & 55 deletions lib/ldclient-rb/impl/integrations/test_data/test_data_source_v2.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,9 +28,6 @@ def initialize(test_data)
@closed = false
@update_queue = Queue.new
@lock = Mutex.new

# Always register for change notifications
@test_data.add_instance(self)
end

#
Expand All @@ -53,68 +50,25 @@ def name
# @return [LaunchDarkly::Interfaces::DataSystem::FetchResult]
#
def fetch(selector_store)
result =
begin
@lock.synchronize do
if @closed
next LaunchDarkly::Result.fail('TestDataV2 source has been closed')
end

# Get all current flags and segments from test data
init_data = @test_data.make_init_data
version = @test_data.get_version

# Build a full transfer changeset
builder = LaunchDarkly::Interfaces::DataSystem::ChangeSetBuilder.new
builder.start(LaunchDarkly::Interfaces::DataSystem::IntentCode::TRANSFER_FULL)

# Add all flags to the changeset
init_data[:flags].each do |key, flag_data|
builder.add_put(
LaunchDarkly::Interfaces::DataSystem::ObjectKind::FLAG,
key,
flag_data[:version] || 1,
flag_data
)
end

# Add all segments to the changeset
init_data[:segments].each do |key, segment_data|
builder.add_put(
LaunchDarkly::Interfaces::DataSystem::ObjectKind::SEGMENT,
key,
segment_data[:version] || 1,
segment_data
)
end

# Create selector for this version
selector = LaunchDarkly::Interfaces::DataSystem::Selector.new_selector(version.to_s, version)
change_set = builder.finish(selector)

basis = LaunchDarkly::Interfaces::DataSystem::Basis.new(change_set: change_set, persist: false, environment_id: nil)

LaunchDarkly::Result.success(basis)
end
rescue => e
LaunchDarkly::Result.fail("Error fetching test data: #{e.message}", e)
end

LaunchDarkly::Interfaces::DataSystem::FetchResult.new(result: result, fallback_to_fdv1: false)
fetch_result do
init_data = @test_data.make_init_data
[init_data, @test_data.get_version]
end
end

#
# Implementation of the Synchronizer.sync method.
#
# Yields updates as test data changes occur.
# Yields the current test data, and then an update for each later change.
#
# @param selector_store [LaunchDarkly::Interfaces::DataSystem::SelectorStore] Provides the Selector (unused for test data)
# @yield [LaunchDarkly::Interfaces::DataSystem::Update] Yields Update objects as synchronization progresses
# @return [void]
#
def sync(selector_store)
# First yield initial data
initial_fetch = fetch(selector_store)
# Subscribe and take the initial data in one step. Then the queue holds only the changes
# that the initial data does not hold.
initial_fetch = fetch_result { @test_data.subscribe(self) }
unless initial_fetch.success?
yield LaunchDarkly::Interfaces::DataSystem::Update.new(
state: LaunchDarkly::Interfaces::DataSource::Status::OFF,
Expand Down Expand Up @@ -287,9 +241,61 @@ def upsert_segment(segment_data)
end
end
end

#
# Builds a full transfer result from the data and the version that the block returns.
# The block runs while this instance holds its lock.
#
private def fetch_result
result =
begin
@lock.synchronize do
if @closed
next LaunchDarkly::Result.fail('TestDataV2 source has been closed')
end

init_data, version = yield

# Build a full transfer changeset
builder = LaunchDarkly::Interfaces::DataSystem::ChangeSetBuilder.new
builder.start(LaunchDarkly::Interfaces::DataSystem::IntentCode::TRANSFER_FULL)

# Add all flags to the changeset
init_data[:flags].each do |key, flag_data|
builder.add_put(
LaunchDarkly::Interfaces::DataSystem::ObjectKind::FLAG,
key,
flag_data[:version] || 1,
flag_data
)
end

# Add all segments to the changeset
init_data[:segments].each do |key, segment_data|
builder.add_put(
LaunchDarkly::Interfaces::DataSystem::ObjectKind::SEGMENT,
key,
segment_data[:version] || 1,
segment_data
)
end

# Create selector for this version
selector = LaunchDarkly::Interfaces::DataSystem::Selector.new_selector(version.to_s, version)
change_set = builder.finish(selector)

basis = LaunchDarkly::Interfaces::DataSystem::Basis.new(change_set: change_set, persist: false, environment_id: nil)

LaunchDarkly::Result.success(basis)
end
rescue => e
LaunchDarkly::Result.fail("Error fetching test data: #{e.message}", e)
end

LaunchDarkly::Interfaces::DataSystem::FetchResult.new(result: result, fallback_to_fdv1: false)
end
end
end
end
end
end

Loading
Loading