Repository navigation
Remove white border and white box on "Join the Conversation" card - #8162
ayushgade06 wants to merge 1 commit into
Conversation
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 3 remain after this review. 📝 WalkthroughWalkthroughThe extra closing brace after ChangesDiscuss callout styling
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~3 minutes Change: Bug fix · Severity of issue fixed: Low Merge Risk: ⚪ Minimal · up to The Discuss callout styling change is ready to merge after normal checks. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
a4b823b to
208ba3a
Compare
|
@PARTH-TUSSLE as discussed in meet I've made the changes to border, will look into the button (Layer 5 Discuss) as per what the figma file suggests |
|
Preview deployment for PR #8162 removed. This PR preview was automatically pruned because we keep only the 3 most recently updated previews on GitHub Pages to stay within deployment size limits. If needed, push a new commit to this PR to generate a fresh preview. |
208ba3a to
70ce445
Compare
…5io#8158) An extra closing brace in discuss.style.js closed the styled-component block early, so the `button` rule (and media queries) fell out of scope and never applied. The button then rendered with the browser's default styling, showing a white border and a white box behind the white Discuss logo on the "Join the Conversation" card. Removing the stray brace re-scopes the rule so `border`/`background` apply as intended. Signed-off-by: Ayush Gade <ayushgade23@gmail.com>
70ce445 to
60cccd8
Compare
|
@PARTH-TUSSLE identified the issue, an extra bracket "}" inside discuss.style.js which caused the rules after that bracket to fall out of scope and not apply, so the button used the browser's default styles instead |
|
@PARTH-TUSSLE could you look into the following PR |
|
Hi @PARTH-TUSSLE , just checking in on this one. The fix is a single-line change in discuss.style.js. It removes the stray } that pushed the following rules out of scope. That removes the white border and the white box behind the logo, and the "Layer5 Discuss" button gets its styles back. It touches every page that renders DiscussCallout. The preview was pruned, so I can push a commit to regenerate it if that helps the review. Thanks! |
Mahakgupta108
left a comment
There was a problem hiding this comment.
lgtm! but just put the video once, as the pr previewed is not available to get this changes verified across all vp and devices.
|
@Mahakgupta108 Thanks for the suggestion, I have added the video for reference |
Description
This PR fixes #8158.
Removes the stray white border around the "Join the Conversation" Discuss card, and the white box behind the logo that makes it hard to read. Affects all pages rendering
DiscussCallout:Notes for Reviewers (After)
Signed Commits
Summary by CodeRabbit