Repository navigation
Conversation
The boot modprobe list now includes nft_compat. On dnf, when iptables is being installed and modprobe -n xt_comment fails, the package script adds kernel-modules for the running kernel, or kernel-uek-modules when the release is UEK, then runs the modprobe script again so those modules are loaded before rootless BuildKit starts. A modules package missing from the repositories yields a warning and the install continues. The Oracle Linux virtiofs path still requests kernel-uek-modules, appends it only when it is not already listed, and UEK repositories are enabled whenever that package is in the extra set. Fixes lima-vm#5623 Signed-off-by: Matt Van Horn <455140+mvanhorn@users.noreply.github.com>
Member
Why not? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What This PR Changes
On AlmaLinux 10, rootless BuildKit exits while its CNI bridge is being added. iptables returns exit status 4 on the nat ACCEPT rule that uses a comment match, warning that extension comment revision 0 is unsupported because a kernel module is missing. The BuildKit service then fails.
iptables-nft serves -m comment through nft_compat together with xt_comment. Guest boot loaded nf_tables and xt_comment and left nft_compat out. On dnf-based guests the xt_comment module is packaged in kernel-modules for the running kernel (kernel-uek-modules on UEK), which is often absent, and rootless iptables cannot autoload that match.
Changes:
Linked Issue (Required in most cases)
Closes #5623
How I Tested This
No local test run is recorded for the lima change to
pkg/cidata/cidata.TEMPLATE.d/boot.Linux/00-modprobe.shandpkg/cidata/cidata.TEMPLATE.d/boot.Linux/30-install-packages.sh.AI Usage
AI was used for assistance.