Skip to content

add ACL support - #18

Merged
lumag merged 3 commits into
linux-msm:masterfrom
lumag:acl
Sep 23, 2023
Merged

add ACL support#18
lumag merged 3 commits into
linux-msm:masterfrom
lumag:acl

Conversation

@lumag

@lumag lumag commented Jul 8, 2023

Copy link
Copy Markdown
Contributor

Implement ACL support to limit visibility of the boards. This allows one to e.g. limit visibility of some of the customer boards to the certain groups of users, while keeping the rest of the lab generally visible to all remote cdba users.

@krzk

krzk commented Jul 13, 2023

Copy link
Copy Markdown
Contributor

Fedora failures are expected, but Debian testing failures are unexpected and need some investigation.

@lumag

lumag commented Jul 13, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Fedora failures are expected, but Debian testing failures are unexpected and need some investigation.

@krzk I'd say, that installing libc6-dev-cross together with cross-arch dev package is a bad idea. Usually I'd dpkg-cross required packages and install resulting host-arch packages.

@krzk

krzk commented Jul 13, 2023

Copy link
Copy Markdown
Contributor

@krzk I'd say, that installing libc6-dev-cross together with cross-arch dev package is a bad idea. Usually I'd dpkg-cross required packages and install resulting host-arch packages.

Do you have an idea how to fix or improve it? If so, then please push :)

@lumag

lumag commented Jul 13, 2023

Copy link
Copy Markdown
Contributor Author

@krzk Debian pipelines pass now, but I've posted suggested improvements anyway as #20 .

@konradybcio

konradybcio commented Sep 21, 2023

Copy link
Copy Markdown
Member

you need to rebase

@lumag

lumag commented Sep 21, 2023

Copy link
Copy Markdown
Contributor Author

you need to rebase

@konradybcio done

konradybcio
konradybcio reviewed Sep 21, 2023
View reviewed changes
Comment thread group.c Resolved
Comment thread Makefile Resolved
Comment thread cdba-server.c Resolved
@lumag
lumag force-pushed the acl branch 2 times, most recently from 93feffe to 15ed414 Compare September 22, 2023 06:42
@lumag
lumag requested a review from konradybcio September 22, 2023 06:42
superna9999
superna9999 reviewed Sep 22, 2023
View reviewed changes
Comment thread device.c Resolved
@lumag
lumag requested a review from superna9999 September 22, 2023 07:38
@lumag
lumag force-pushed the acl branch 2 times, most recently from a688f8e to f13d13c Compare September 22, 2023 22:59
konradybcio
konradybcio approved these changes Sep 23, 2023
View reviewed changes

@konradybcio konradybcio left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can't see anything obviously wrong

Dmitry Baryshkov added 3 commits September 23, 2023 16:50
Dmitry Baryshkov
device: implement access control to the boards
3ea8df6 
Limit access control to the boards according to the passed username. If
the user has no access, the board becoms completely invisible: it is not
listed, it is not possible to fetch board description, etc.

Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Dmitry Baryshkov
README: update config file syntax
5164ca9 
Describe optional user/group/device mapping in the config file example.

Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Dmitry Baryshkov
cdba-shell: set the CDBA_USER variable
926ca24 
Set and export the CDBA_USER variable to enable ACL in cdba-server.

Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
@lumag
lumag merged commit 757f8e5 into linux-msm:master Sep 23, 2023
@lumag
lumag deleted the acl branch September 23, 2023 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@superna9999 superna9999 superna9999 approved these changes
@konradybcio konradybcio konradybcio approved these changes
@krzk krzk Awaiting requested review from krzk

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@lumag @krzk @konradybcio @superna9999