Repository navigation
support ppps usb control - #33
Merged
Merged
Conversation
This was referenced Sep 24, 2023
lumag
reviewed
Sep 24, 2023
lumag
reviewed
Sep 24, 2023
| #include "device.h" | ||
|
|
||
| #define PPPS_BASE_PATH "/sys/bus/usb/devices/" | ||
| #define PPPS_BASE_PATH_LEN strlen(PPPS_BASE_PATH) |
Contributor
There was a problem hiding this comment.
I know that uhubctl toggles both USB 2 and USB 3 hubs to fully toggle the power. Let me check if toggling just one of them is enough for e.g. UUGEAR hub.
Member
Author
There was a problem hiding this comment.
On my setup I just always disable the usb 3.0 part, the oneplus devices don't support superspeed anyway so it was just easier. imo this can be extended if someone needs it...
Contributor
There was a problem hiding this comment.
Getting rid of uhubctl would be nice. I'll look into this after merging this PR. Fortunately the hub has LED showing whether vbus is enabled or not.
lumag
reviewed
Sep 24, 2023
lumag
requested changes
Sep 24, 2023
kcxt
force-pushed
the
ppps
branch
2 times, most recently
from
September 28, 2023 09:49
fa17d6f to
0b841a3
Compare
lumag
reviewed
Sep 28, 2023
lumag
approved these changes
Sep 28, 2023
kcxt
force-pushed
the
ppps
branch
3 times, most recently
from
September 28, 2023 10:06
2d8939f to
d526cf9
Compare
Since Linux kernel 6.0, PPPS capable USB hubs expose a simple sysfs attribute for power control. Allow overwriting the usb control callback to use PPPS hub control instead. Signed-off-by: Caleb Connolly <caleb.connolly@linaro.org>
Musl requires that this header be explicitly included for O_CREAT, O_CLOEXEC, etc. Signed-off-by: Caleb Connolly <caleb.connolly@linaro.org>
kcxt
force-pushed
the
ppps
branch
2 times, most recently
from
September 28, 2023 10:36
17df128 to
d360973
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since Linux kernel 6.0, PPPS capable USB hubs expose a simple sysfs attribute for power control. Allow overwriting the usb control callback to use PPPS hub control instead.
This really simply allows for combining a PPPS hub with some other control board like a micro controller implementing the qcomlt_debug_board interface.