Repository navigation
For linux msm/sahara mode match - #343
Open
quic-bjorande wants to merge 2 commits into
Open
quic-bjorande wants to merge 2 commits into
quic-bjorande wants to merge 2 commits into
Conversation
QDL mirrors the mode supplied by Sahara HELLO regardless of the requested operation. Running flash against a device in memory-debug mode can therefore enter ramdump processing without an output path, while the inverse mismatch fails indirectly. Reject a HELLO mode that does not match the selected flash or ramdump operation before sending a response or processing mode-specific packets. Closes: linux-msm#312 Signed-off-by: Bjorn Andersson <bjorn.andersson@oss.qualcomm.com>
Sahara mode mismatches previously progressed into the handler selected by the device rather than the requested QDL operation. Exercise both supported modes and both mismatch directions so validation remains before any mode-specific packet is consumed or response is written. Closes: linux-msm#312 Signed-off-by: Bjorn Andersson <bjorn.andersson@oss.qualcomm.com>
quic-bjorande
force-pushed
the
for-linux-msm/sahara-mode-match
branch
from
October 19, 2026 03:12
1c800ce to
44274d6
Compare
igoropaniuk
reviewed
Nov 10, 2026
igoropaniuk
left a comment
igoropaniuk
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the PR. Could you also rebased onto the latest master? Thanks!
|
|
||
| return sahara_send_hello_resp(qdl, SAHARA_VERSION, pkt->hello_req.mode); | ||
| if (pkt->hello_req.mode != expected_mode) { | ||
| ux_err("Sahara mode mismatch: device is in %s mode, but %s was requested\n", |
Contributor
There was a problem hiding this comment.
could you switch to ux_err_tag() instead :
ux_err_tag(UX_TAG_SAHARA, "mode mismatch: device is in %s mode, but %s was requested\n",
sahara_mode_name(pkt->hello_req.mode),
sahara_mode_name(expected_mode));
| case SAHARA_MODE_COMMAND: | ||
| return "command"; | ||
| default: | ||
| return "unknown"; |
Contributor
There was a problem hiding this comment.
can we elaborate and add print mode raw number as well (e.g. "unknown (0x%x)")
Contributor
|
nit: both commits carry |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.