Repository navigation
keybindings (wayland): Notify the shell of layout switches during a grab - #896
Open
SeniorMatt wants to merge 1 commit into
Open
SeniorMatt wants to merge 1 commit into
SeniorMatt wants to merge 1 commit into
Conversation
…rab. With a layout switch such as grp:caps_toggle, pressing it while dragging a window switches the typing layout but the shell's indicator does not follow, and the next press seems to do nothing. During a move/resize grab window->all_keys_grabbed is TRUE and process_key_event() skipped process_iso_next_group(), so modifiers-accelerator-activated was never emitted. Under Wayland xkbcommon has already applied the group change to the seat's xkb state, and the native backend only emits keymap-layout-group-changed from lock_layout_group(), so nothing else tells the shell. Run process_iso_next_group() during the grab under Wayland too. Under X11 the handler may ungrab the keyboard and end the move grab, so keep the old behaviour there.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With a layout toggle like
grp:caps_toggle, pressing it while dragging a window switched the layout, but the Cinnamon indicator didn't follow, and the next press seemed to do nothing.During a move/resize grab
process_iso_next_group()is skipped, somodifiers-accelerator-activatedis never emitted, while on Wayland xkbcommon has already switched the group. This runs it during the grab on Wayland only; X11 is unchanged, since there the handler can ungrab and end the move.Tested on Mint 27 (Wayland): switching with Caps Lock during a drag works and the indicator follows.