Repository navigation
Homepage agent: protect against pre-connect audio and memory bugs - #8447
Open
thomasyuill-livekit wants to merge 1 commit into
Open
thomasyuill-livekit wants to merge 1 commit into
thomasyuill-livekit wants to merge 1 commit into
Conversation
- Set pre_connect_audio=False to remove AGT-3919 vulnerability - Set job_memory_limit_mb=600 to contain memory-related bugs - Keep session_host enabled as homepage dev panel uses lk.agent.session stream Addresses AGT-3919 (pre-connect audio infinite loop) and AGT-3920 (unbounded session stream reader) by disabling the unused pre-connect audio feature and capping job memory usage at 600 MB. Co-authored-by: ThomFoolery <thomasyuill-livekit@users.noreply.github.com>
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
🔍 Devin Review: 1 flag
Not posted on this PR by your GitHub settings — view it in Devin Review. (Configure)
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements configuration changes to protect the livekit.io homepage voice agent against two framework bugs:
Changes
Set
pre_connect_audio=Falsein the audio input optionsSet
job_memory_limit_mb=600on the AgentServerKeep
session_hostenabled (default behavior)lk.agent.sessionbyte stream (seebehaviors/frontend_attributes.py)session_host=Falsewould break this functionalityTesting
Closes MARKT-1576
Fixes MARKT-1576