Repository navigation
[mailbox,dv] Add the first functional coverage model - #790
Open
martin-velay wants to merge 2 commits into
Open
martin-velay wants to merge 2 commits into
martin-velay wants to merge 2 commits into
Conversation
The V1 checklist asks for the interrupts to be connected in the testbench. Publish irq_o as intr_vif and keep it in the environment configuration for the V2 interrupt checks. Signed-off-by: Martin Velay <mvelay@lowrisc.org>
martin-velay
force-pushed
the
mailbox_dv_fcov
branch
2 times, most recently
from
November 11, 2026 07:40
b700a2c to
40581de
Compare
Cover FIFO accesses, STATUS reads, threshold writes, every access, cross-port concurrency and reset, sampled by the scoreboard once it has checked an access. The interrupt, error and flush covergroups come with their V2 models. Give the vPlan features these covergroups answer their items. Signed-off-by: Martin Velay <mvelay@lowrisc.org>
martin-velay
force-pushed
the
mailbox_dv_fcov
branch
from
November 11, 2026 08:20
40581de to
6d35bae
Compare
martin-velay
marked this pull request as ready for review
November 11, 2026 08:21
tchilikov-semify
approved these changes
Nov 11, 2026
tchilikov-semify
left a comment
Collaborator
There was a problem hiding this comment.
Looks good to me, only one minor question, but otherwise I think this PR is good to merge!
| mailbox_state state = copy(); | ||
| mailbox_result_t result = '{resp: RespOkay, data: '0}; | ||
|
|
||
| if (acc.kind inside {AccessMboxW, AccessMboxR, AccessStatus}) begin |
Collaborator
There was a problem hiding this comment.
Nit: is seen only for coverage? If so, would it make sense to add an if (cfg.en_cov) guard so it doesnt always sample?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of the mailbox block-level DV (#173), for the V1
SIM_COVERAGE_MODEL_ADDEDitem. Stacked on #784, so its first commit goes away once #784 merges.Adds
mailbox_env_covwith six of the eleven covergroups in the DV document:fifo_cg,status_cg,threshold_cg,access_cg,concurrency_cgandreset_cg. The scoreboard samples them after each check, and uses a model value only when every state it keeps agrees on it. The interrupt, error and flush covergroups come in V2 with the scoreboard models they need.The vPlan features these covergroups answer now carry their items. Features with an open question on #755 keep none, as the vPlan header says.
All V1 tests pass on Xcelium with
--cov, anddata_transfer, the V1 feature among them, is at 100%.