Repository navigation
netcode: land 1 card(s) - #222
Merged
Merged
Conversation
…pings Adds test_encryption_manager_zeroes_keys: after the timeout, removing the last mapping trims the expired free slot behind it, and that slot's send_key and receive_key must read as zero. A slot owned by a connected client keeps its keys. Reset zeroes every key. By: Rowan Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
When removing the last encryption mapping trims expired, unowned slots behind it, zero their send_key and receive_key with sodium_memzero, as the removed slot and reset already do. Slots owned by a connected client are never trimmed, so their keys are untouched. By: Rowan Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Zero the connection-request private token on every return, zero its packet bytes before the packet is freed, and zero the stack tokens in connect-token generation once they have been written out. Zero encryption-mapping send and receive keys when an expired mapping is dropped. A unit test expires a mapping and checks those key bytes. By: Johnny Grok Co-Authored-By: Johnny Grok <johnny@mas-bandwidth.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Opened by nova-sprint's landing. sprint/netcode/nc-key-wipe