Skip to content

Fix Build issues from using vcpkg port - #354

Merged
oschwald merged 1 commit into
maxmind:mainfrom
ankurvdev:ankurvdev-patch-1
Aug 21, 2024
Merged

oschwald merged 1 commit into
maxmind:mainfrom
ankurvdev:ankurvdev-patch-1

Conversation

@ankurvdev

Copy link
Copy Markdown
Contributor

Using the maxminddb vcpkg port causes a unnecessary include to a private build "generated" folder that is found when using pre-built vcpkg libraries in another project

Using the maxminddb vcpkg port causes a unnecessary include to a private build "generated" folder that is found when using pre-built vcpkg libraries in another project

@oschwald oschwald left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@oschwald
oschwald merged commit ee4449b into maxmind:main Aug 21, 2024
@ankurvdev

Copy link
Copy Markdown
Contributor Author

Thanks for merging.
For fixing the vcpkg port would it be possible to make a release anytime soon. So we can just move vcpkg to a newer release ?

@ankurvdev
ankurvdev deleted the ankurvdev-patch-1 branch August 21, 2024 17:44
@oschwald

Copy link
Copy Markdown
Member

I released 1.11.0 with this change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants