Repository navigation
Support keyboard action chains in command mode - #4266
Draft
hafizahmedzia wants to merge 3 commits into
Draft
hafizahmedzia wants to merge 3 commits into
hafizahmedzia wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Custom command-bar bindings can now chain built-in command and buffer keyboard actions through one resolver and a command-context adapter. Comma sequencing and &/| short-circuit behavior handle prompt closure or replacement while keeping document edits isolated. Existing raw, mouse and mixed-sequence single bindings and shared prefixes are preserved.
Refs #4019. Thanks to injust for describing the gap. This is a bounded enhancement for maintainer discussion: new chains cover keyboard keys and keyboard-only sequences. It does not add command:, command-edit:, lua: or mouse-chain parity, and it leaves the #3973 default-shortcut workaround in place. It does not claim full issue closure.
Validation performed previously on Linux at e207f97: the final new regression failed as expected on the unchanged source and passed with this corrected patch. Focused tests, make test, uncached go test ./... and make build passed with Go 1.27.2. Focused/full uncached tests, build and a controlling-PTY smoke test also passed with the declared minimum Go 1.19.13. Independent compatibility probes and the full uncached Go suite passed on this final revision.
Native macOS/Windows, intermediate CI Go versions and visual terminal screenshots remain unrun.
Prepared with OpenAI Codex assistance for implementation, tests and validation.