Skip to content
This repository was archived by the owner on Jul 8, 2024. It is now read-only.
This repository was archived by the owner on Jul 8, 2024. It is now read-only.

Module directories lower case #79

Open

Description

In the following documentation we see that module directory names must be lower case but the module binary name can be upper case. Is there a particular reason for changing the case? Does something go wrong if we choose it to be exactly the same as the module binary name?

https://github.com/awf/ADBench/blob/18dcb403aa50895a8700d69ea83253eab9079a39/docs/cpp/Modules.md#adding-new-modules

Activity

  1. novikov-alexander-zz commented on Sep 11, 2019

    @novikov-alexander-zz
    Contributor

    run-all script uses this convention to run modules in the current implementation.
    But I don't see any obstacles to rename existing folders and change run-all script to meet your convention.

  2. tomjaguarpaw commented on Sep 11, 2019

    @tomjaguarpaw
    CollaboratorAuthor

    I think it would make life a simpler if there is no difference between the two. Let's leave this issue open for a bit in case anyone else knows a reason why we shouldn't change it.

  3. novikov-alexander-zz commented on Sep 11, 2019

    @novikov-alexander-zz
    Contributor

    I've discussed it with Dmitry Kats (@msdmkats) and we concluded that there are no any other special reasons. So, I will close this issue after I fix it.

  4. tomjaguarpaw commented on Sep 11, 2019

    @tomjaguarpaw
    CollaboratorAuthor

    OK, that will be great.

  5. novikov-alexander-zz commented on Oct 2, 2019

    @novikov-alexander-zz
    Contributor

    Sorry, I don't have time to finish it. So, it will be closed when someone else fix it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions