Repository navigation
Suppress DS173237 on all-zero values - #709
Merged
Giulia Stocco (gfs) merged 4 commits intoFeb 5, 2026
Merged
Conversation
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Contributor
|
/azp run |
|
No pipelines are associated with this pull request. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR suppresses false positives in DS173237 (secret detection rule) by excluding strings that contain only zeros, which commonly appear in placeholders and test data.
Changes:
- Added a new condition to DS173237 rule to exclude all-zero values from being flagged as potential secrets
- Added test case to verify all-zero strings are not matched
- Minor JSON formatting improvements (consistent spacing around colons)
- Updated changelog with version 1.0.72
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| rules/default/security/privacy/secrets.json | Added condition pattern to suppress all-zero values in DS173237, included test case, and improved JSON formatting consistency |
| Changelog.md | Added version 1.0.72 entry documenting the DS173237 fix |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Giulia Stocco (gfs)
previously approved these changes
Feb 4, 2026
Dan Fiedler (danfiedler-msft)
previously approved these changes
Feb 5, 2026
Giulia Stocco (gfs)
dismissed stale reviews from Dan Fiedler (danfiedler-msft) and themself
via
February 5, 2026 16:30
ea4c4b8
Giulia Stocco (gfs)
enabled auto-merge (squash)
February 5, 2026 16:31
Giulia Stocco (gfs)
disabled auto-merge
February 5, 2026 16:31
Giulia Stocco (gfs)
enabled auto-merge (squash)
February 5, 2026 16:31
Contributor
|
/azp run |
|
No pipelines are associated with this pull request. |
Michael Scovetta (scovetta)
approved these changes
Feb 5, 2026
Member
Author
|
Thanks all! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR proposes to exclude all-zero values from matching the rule for DS173237. These are unlikely to represent secrets and strings of this format can often appear in placeholders or test-related data.