Repository navigation
Conversation
Keep option round-trip assertions in the descriptor test and the nonzero identity assertion in the thread identity test. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues remain for the integration-test consolidation.
No open issues 🎉
What changed in this PR
This PR consolidates overlapping allocation_hints integration tests while preserving the removed tests’ assertions. Production code is unchanged.
Changes:
- Merge the general-options round-trip assertions into the heap descriptor test, using nondefault options.
- Move the nonzero thread ID assertion into the existing thread identity test.
- Keep the dedicated default-value test unchanged.
| File | Description |
|---|---|
crates/allocation_hints/tests/heaps.rs |
Consolidates option and thread identity checks into existing tests. |
Review effort: Balanced
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #994 +/- ##
=========================================
Coverage 99.9% 100.0%
=========================================
Files 851 2 -849
Lines 74592 199 -74393
=========================================
- Hits 74583 199 -74384
+ Misses 9 0 -9
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This is an automated mechanical PR for
allocation_hints.Combine the general option round-trip test with the descriptor test. Move the nonzero thread identity assertion into the existing thread identity test. Preserve the assertions from both removed tests. Only
crates/allocation_hints/tests/heaps.rschanges.Evidence
cargo check -p allocation_hintspassed with Rust 1.97.cargo test -p allocation_hintspassed all 20 tests and two documentation tests.git diff --checkpassed. Anvil CI covers broader validation and remains pending.Merge Danger
Low risk. No production code, dependencies, or shared files change. Consolidation reduces separate test isolation and changes the descriptor test to use nondefault options. The dedicated default-value test remains.