Skip to content

test(allocation_hints): consolidate overlapping heap tests - #994

Open
martintmk wants to merge 1 commit into
mainfrom
martintmk-allocation-hints-duplicate-tests
Open

martintmk wants to merge 1 commit into
mainfrom
martintmk-allocation-hints-duplicate-tests

Conversation

@martintmk

Copy link
Copy Markdown
Member

Summary

This is an automated mechanical PR for allocation_hints.

Combine the general option round-trip test with the descriptor test. Move the nonzero thread identity assertion into the existing thread identity test. Preserve the assertions from both removed tests. Only crates/allocation_hints/tests/heaps.rs changes.

Evidence

cargo check -p allocation_hints passed with Rust 1.97. cargo test -p allocation_hints passed all 20 tests and two documentation tests. git diff --check passed. Anvil CI covers broader validation and remains pending.

Merge Danger

Low risk. No production code, dependencies, or shared files change. Consolidation reduces separate test isolation and changes the descriptor test to use nondefault options. The dedicated default-value test remains.

Keep option round-trip assertions in the descriptor test and the nonzero identity assertion in the thread identity test.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot AI balanced review requested due to automatic review settings November 19, 2026 15:59

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues remain for the integration-test consolidation.

No open issues 🎉

What changed in this PR

This PR consolidates overlapping allocation_hints integration tests while preserving the removed tests’ assertions. Production code is unchanged.

Changes:

  • Merge the general-options round-trip assertions into the heap descriptor test, using nondefault options.
  • Move the nonzero thread ID assertion into the existing thread identity test.
  • Keep the dedicated default-value test unchanged.
File Description
crates/​allocation_hints/​tests/​heaps.rs Consolidates option and thread identity checks into existing tests.

Review effort: Balanced

@codecov

codecov Bot commented Nov 19, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.0%. Comparing base (6542ec1) to head (9de7c7e).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##            main     #994      +/-   ##
=========================================
  Coverage   99.9%   100.0%              
=========================================
  Files        851        2     -849     
  Lines      74592      199   -74393     
=========================================
- Hits       74583      199   -74384     
+ Misses         9        0       -9     
Flag Coverage Δ
linux 100.0% <ø> (ø)
linux-arm 100.0% <ø> (ø)
scheduled ?
windows 100.0% <ø> (+<0.1%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants