Repository navigation
fix(transform): tolerate concurrent compilation cache writes - #43616
microsoft-playwright-automation[bot] wants to merge 1 commit into
Conversation
Test results for "MCP"1 failed 5188 passed, 614 skipped Merge workflow run. |
Test results for "tests 1"1 flaky23558 passed, 702 skipped Merge workflow run. |
🟡 One CI failure remains uncertainHi, I'm the Playwright bot. I checked the PR changes, the failed job, and the updated CI test history. DetailsThere is no clear evidence that #43616 caused the reported MCP failure, but I could not confirm a pre-existing flake either. Uncertain — macOS/Chrome MCP
The PR changes compilation-cache cleanup and cache-write error handling, not MCP origin filtering. That compiler is shared by the test runner, so the diff alone cannot rule out an effect. The same test passed in all six other browser/platform configurations in this run; that is supporting context, not proof of a flake. After refreshing the test-results database, the exact Rerun the macOS/Chrome job. If it fails again, compare the PR revision with its base on macOS and capture MCP subprocess diagnostics to locate the stalled operation. Triaged by the Playwright bot - agent run |
Concurrent runners delete the current transform-cache entry while another runner writes it. On Windows this can make an otherwise successful compilation fail with
EPERM.Preserve the current revision during cleanup. If writing a cache entry fails, log the error and continue with the compiled code without publishing that entry.
The new regression test injects failed map and code writes during ESM discovery. The existing clear-cache and sequential revision-cleanup tests cannot install this failure without changing their setup.
Verified the regression fails before the fix and passes afterward; all 66 cache/loader tests,
npm run build, andnpm run flintpass on Windows. A four-process stress run completed 12,187 shared-cache writes without an exception. No browser is involved.Fixes: #43601
Prepared by the triage workflow.