Hide continuation-token parameters on nextLink-paged C# operations by Copilot · Pull Request #12469 · microsoft/typespec

Copilot · 2026-11-02T17:32:49Z

nextLink-paged operations can expose a bare continuation-token request parameter even though callers resume paging with a nextLink URL. These incompatible token formats invite incorrect requests.

Metadata: Preserve the request-token marker even when the response has no continuation token.
Public API: Omit marked tokens from sync/async convenience and protocol signatures; pass default internally. Leave token-only paging unchanged.
Compatibility: Retain published token-bearing signatures as [EditorBrowsable(Never)] overloads that still send the token, preserve trailing optional arguments, and coexist with optional-parameter compatibility overloads.

Representative convenience signature:

- GetRooms(int? maxPageSize = default, string continuationToken = default, CancellationToken cancellationToken = default)
+ GetRooms(int? maxPageSize = default, CancellationToken cancellationToken = default)

Fixes Don't expose a @continuationToken request parameter on nextLink-paged operations #12468

azure-pipelines · 2026-11-02T17:33:18Z

Azure Pipelines: Successfully started running 1 pipeline(s). 1 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run.

Co-authored-by: jorgerangel-msft <102122018+jorgerangel-msft@users.noreply.github.com>

pkg-pr-new · 2026-11-02T17:55:31Z

Open in StackBlitz

npm i https://pkg.pr.new/@typespec/http-client-csharp@12469

commit: 871a1b2

… overloads Co-authored-by: jorgerangel-msft <102122018+jorgerangel-msft@users.noreply.github.com>

…ressions Co-authored-by: jorgerangel-msft <102122018+jorgerangel-msft@users.noreply.github.com>

Add opt-in SupportsPageResumption to the response APIs and preserve unbranded paging signatures by default. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

github-actions · 2026-11-02T20:51:37Z

No changes needing a change description found.

Replace the paging metadata reference with IsContinuationToken and preserve grouped parameter forwarding and unbranded paging behavior. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Move isContinuationToken to InputPropertyTypeBase and remove InputHttpParameterBase. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot

🟡 Changes recommended

Critical overload-matching and paging-argument errors can drop published tokenless methods and generate invalid constructor calls, breaking compilation and backward compatibility.

3 open issues

What changed in this PR

This PR adds support for hiding raw continuation-token parameters on nextLink-paged C# operations when the response provider supports page resumption, addressing #12468.

Changes:

Preserve request continuation-token metadata independently of response-token metadata.
Omit marked tokens from eligible public signatures and pass default internally, leaving token-only paging unchanged.
Add hidden compatibility overloads, regression tests, and updated code-model fixtures.

Paths below are relative to packages/http-client-csharp/.

File	Description
`generator/TestProjects/Spector/http/payload/pageable/tspCodeModel.json`	Update paging token markers.
`generator/TestProjects/Local/Sample-TypeSpec/tspCodeModel.json`	Update sample token markers.
`generator/Microsoft.TypeSpec.Generator.Input/test/TypeSpecInputConverterTests.cs`	Test marker deserialization and updates.
`generator/Microsoft.TypeSpec.Generator.Input/src/InputTypes/Serialization/InputQueryParameterConverter.cs`	Deserialize query token markers.
`generator/Microsoft.TypeSpec.Generator.Input/src/InputTypes/Serialization/InputPathParameterConverter.cs`	Deserialize path token markers.
`generator/Microsoft.TypeSpec.Generator.Input/src/InputTypes/Serialization/InputMethodParameterConverter.cs`	Deserialize method token markers.
`generator/Microsoft.TypeSpec.Generator.Input/src/InputTypes/Serialization/InputHeaderParameterConverter.cs`	Deserialize header token markers.
`generator/Microsoft.TypeSpec.Generator.Input/src/InputTypes/Serialization/InputEndpointParameterConverter.cs`	Deserialize endpoint token markers.
`generator/Microsoft.TypeSpec.Generator.Input/src/InputTypes/Serialization/InputBodyParameterConverter.cs`	Deserialize body token markers.
`generator/Microsoft.TypeSpec.Generator.Input/src/InputTypes/InputParameter.cs`	Store and update token metadata.
`generator/Microsoft.TypeSpec.Generator.ClientModel/test/TestHelpers/ResumableClientResultProvider.cs`	Add a resumption-capable test provider.
`generator/Microsoft.TypeSpec.Generator.ClientModel/test/TestHelpers/MockHelpers.cs`	Allow response-provider injection in async setup.
`generator/Microsoft.TypeSpec.Generator.ClientModel/test/Providers/ScmMethodProviderCollectionTests.cs`	Test token omission and options-bag preservation.
`generator/Microsoft.TypeSpec.Generator.ClientModel/test/Providers/ClientProviders/TestData/ClientProviderTests/BackCompatibility_NextLinkContinuationToken/TestClient.cs`	Define published token-bearing test signatures.
`generator/Microsoft.TypeSpec.Generator.ClientModel/test/Providers/ClientProviders/ClientProviderTests.cs`	Test hidden compatibility overloads.
`generator/Microsoft.TypeSpec.Generator.ClientModel/test/Providers/Abstractions/ClientResponseApiTests.cs`	Test page-resumption capability defaults and overrides.
`generator/Microsoft.TypeSpec.Generator.ClientModel/src/Providers/ScmMethodProviderCollection.cs`	Filter tokens and preserve internal argument forwarding.
`generator/Microsoft.TypeSpec.Generator.ClientModel/src/Providers/ClientProvider.cs`	Integrate token-bearing compatibility overloads.
`generator/Microsoft.TypeSpec.Generator.ClientModel/src/Providers/Abstractions/IClientResponseApi.cs`	Define the page-resumption capability.
`generator/Microsoft.TypeSpec.Generator.ClientModel/src/Providers/Abstractions/ClientResponseApi.cs`	Expose an overridable capability flag.
`emitter/test/Unit/operation-paging.test.ts`	Test request-token metadata preservation.
`emitter/src/type/input-type.ts`	Add optional token metadata to the input schema.
`emitter/src/lib/operation-converter.ts`	Mark request tokens without requiring response tokens.

_{Review effort: Balanced}

…ation Co-authored-by: jorgerangel-msft <102122018+jorgerangel-msft@users.noreply.github.com>

Merge current main, retaining continuation-token tests and honoring the lifecycle visibility revert. Warn and retain raw-token APIs on signature collisions, preserve published tokenless methods during regeneration, and fix mixed grouped parameter forwarding. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot

🟡 Changes recommended

Page-resumption overload generation can leave public partial methods without implementations, causing CS8795, and make previously valid calls ambiguous through overlapping optional arguments.

2 open issues

3 resolved since last review

_{Review effort: Balanced}

Retain renamed partial implementations, handle optional-argument and custom-code collisions, generalize the signature-collision warning, and streamline token filtering and compatibility allocations. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot

🟡 Changes recommended

Critical compatibility regressions can produce duplicate partial implementations, make previously valid calls ambiguous, and omit published continuation-token overloads.

2 open issues

1 previously missed issue

In code that hasn't changed since last review

Match the published token parameter by position

packages/http-client-csharp/generator/Microsoft.TypeSpec.Generator.ClientModel/src/Providers/ScmMethodProviderCollection.cs:292

If the last contract names the token resumeToken but the current input names it token and there is no current partial declaration, this name check returns -1, so AddContinuationTokenOverloads never retains the published overload (for example, using the existing CustomProtocolLast fixture without CustomProtocol). Match the baseline parameter structurally/positionally and restore its published name, rather than requiring it to match the current token name.

2 resolved since last review

_{Review effort: Balanced}

Deduplicate grouped partial implementations, preserve null/default call compatibility, simplify method construction, and verify request builders with file-based baselines. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Merge main, preserving converter-test coverage. Clarify the token-omission policy helper, split assignments, cover empty segments, and validate generated code through TestData baselines. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot

🟡 Changes recommended

Critical overload-collision gaps can drop required partial implementations and introduce ambiguous calls, causing compilation failures for customizations and published contracts.

3 open issues

2 resolved since last review

_{Review effort: Balanced}

Recognize renamed custom tokens, prioritize explicit partial implementations, and detect collisions across all argument counts. Simplify legacy caching and generated suppression comments with regression coverage. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot

🔵 Needs a closer look

Human assessment is needed because subtle named-argument and optional-parameter interactions can make previously valid paging calls fail to compile or become ambiguous.

No open issues 🎉

3 resolved since last review

_{Review effort: Balanced}

Initial plan

bdd2611

Copilot AI assigned Copilot and Jorge Rangel (jorgerangel-msft) Nov 2, 2026

Copilot started work on behalf of Jorge Rangel (jorgerangel-msft) November 2, 2026 17:33

View session

Copilot AI linked an issue Nov 2, 2026 that may be closed by this pull request

Don't expose a @continuationToken request parameter on nextLink-paged operations #12468

Open

github-actions Bot mentioned this pull request Nov 2, 2026

Don't expose a @continuationToken request parameter on nextLink-paged operations #12468

Open

fix(http-client-csharp): hide nextLink continuation-token parameters

40e8d54

Co-authored-by: jorgerangel-msft <102122018+jorgerangel-msft@users.noreply.github.com>

microsoft-github-policy-service Bot added the emitter:client:csharp Issue for the C# client emitter: @typespec/http-client-csharp label Nov 2, 2026

test(http-client-csharp): strengthen nextLink compatibility coverage

faa7c3c

Co-authored-by: jorgerangel-msft <102122018+jorgerangel-msft@users.noreply.github.com>

fix(http-client-csharp): preserve optional arguments on legacy paging…

765d1e7

… overloads Co-authored-by: jorgerangel-msft <102122018+jorgerangel-msft@users.noreply.github.com>

Copilot AI changed the title ~~[WIP] Fix exposure of @continuationToken request parameter~~ Hide continuation-token parameters on nextLink-paged C# operations Nov 2, 2026

Copilot AI requested a review from Jorge Rangel (jorgerangel-msft) November 2, 2026 18:07

Copilot finished work on behalf of Jorge Rangel (jorgerangel-msft) November 2, 2026 18:07

Jorge Rangel (jorgerangel-msft) reviewed Nov 2, 2026

View reviewed changes

Comment thread packages/http-client-csharp/emitter/src/lib/operation-converter.ts Resolved

Copilot started work on behalf of Jorge Rangel (jorgerangel-msft) November 2, 2026 19:28

View session

fix(http-client-csharp): preserve existing compatibility warning supp…

a375a2a

…ressions Co-authored-by: jorgerangel-msft <102122018+jorgerangel-msft@users.noreply.github.com>

Copilot finished work on behalf of Jorge Rangel (jorgerangel-msft) November 2, 2026 19:47

Copilot AI requested a review from Jorge Rangel (jorgerangel-msft) November 2, 2026 19:47

fix(http-client-csharp): gate token suppression on page resumption

757615a

Add opt-in SupportsPageResumption to the response APIs and preserve unbranded paging signatures by default. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Jorge Rangel (jorgerangel-msft) and others added 2 commits November 2, 2026 15:48

refactor(http-client-csharp): mark continuation tokens on parameters

c847a87

Replace the paging metadata reference with IsContinuationToken and preserve grouped parameter forwarding and unbranded paging behavior. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

refactor(http-client-csharp): use shared property base for token marker

e746e14

Move isContinuationToken to InputPropertyTypeBase and remove InputHttpParameterBase. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Jorge Rangel (jorgerangel-msft) reviewed Nov 2, 2026

View reviewed changes

Jorge Rangel (jorgerangel-msft) requested a balanced review from Copilot November 2, 2026 22:34

Copilot started reviewing on behalf of Jorge Rangel (jorgerangel-msft) November 2, 2026 22:34

View session

Copilot started work on behalf of Jorge Rangel (jorgerangel-msft) November 2, 2026 22:35

View session

Copilot AI reviewed Nov 2, 2026

View reviewed changes

refactor(http-client-csharp): streamline nextLink compatibility gener…

ca91600

…ation Co-authored-by: jorgerangel-msft <102122018+jorgerangel-msft@users.noreply.github.com>

Copilot finished work on behalf of Jorge Rangel (jorgerangel-msft) November 2, 2026 23:08

Copilot AI requested a review from Jorge Rangel (jorgerangel-msft) November 2, 2026 23:08

Jorge Rangel (jorgerangel-msft) requested a balanced review from Copilot November 4, 2026 21:36

Copilot started reviewing on behalf of Jorge Rangel (jorgerangel-msft) November 4, 2026 21:37

View session

Copilot AI reviewed Nov 4, 2026

View reviewed changes

Comment thread ...erator/Microsoft.TypeSpec.Generator.ClientModel/src/Providers/ScmMethodProviderCollection.cs Resolved

Comment thread ...erator/Microsoft.TypeSpec.Generator.ClientModel/src/Providers/ScmMethodProviderCollection.cs Resolved

Jorge Rangel (jorgerangel-msft) reviewed Nov 4, 2026

View reviewed changes

Jorge Rangel (jorgerangel-msft) requested a balanced review from Copilot November 5, 2026 00:05

Copilot started reviewing on behalf of Jorge Rangel (jorgerangel-msft) November 5, 2026 00:06

View session

Copilot AI reviewed Nov 5, 2026

View reviewed changes

Comment thread ...erator/Microsoft.TypeSpec.Generator.ClientModel/src/Providers/ScmMethodProviderCollection.cs Resolved

Comment thread ...erator/Microsoft.TypeSpec.Generator.ClientModel/src/Providers/ScmMethodProviderCollection.cs Resolved

Jorge Rangel (jorgerangel-msft) reviewed Nov 5, 2026

View reviewed changes

Jorge Rangel (jorgerangel-msft) reviewed Nov 6, 2026

View reviewed changes

Jorge Rangel (jorgerangel-msft) requested a balanced review from Copilot November 6, 2026 20:19

Copilot started reviewing on behalf of Jorge Rangel (jorgerangel-msft) November 6, 2026 20:19

View session

Copilot AI reviewed Nov 6, 2026

View reviewed changes

Jorge Rangel (jorgerangel-msft) reviewed Nov 6, 2026

View reviewed changes

Jorge Rangel (jorgerangel-msft) requested a balanced review from Copilot November 6, 2026 20:48

Copilot started reviewing on behalf of Jorge Rangel (jorgerangel-msft) November 6, 2026 20:49

View session

Copilot AI reviewed Nov 6, 2026

View reviewed changes

Merge branch 'main' into copilot/dont-expose-continuationtoken

871a1b2

Conversation

Copilot AI commented Nov 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

azure-pipelines Bot commented Nov 2, 2026

Uh oh!

pkg-pr-new Bot commented Nov 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

github-actions Bot commented Nov 2, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🟡 Changes recommended

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🟡 Changes recommended

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🟡 Changes recommended

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🟡 Changes recommended

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🔵 Needs a closer look

Uh oh!

This branch has not been deployed

Reviewers

Uh oh!

Copilot AI commented Nov 2, 2026 •

edited

Loading

pkg-pr-new Bot commented Nov 2, 2026 •

edited

Loading