Repository navigation
fix(http-client-python): preserve renamed body example values - #12480
Draft
Libba Lawrence (l0lawrence) wants to merge 1 commit into
Draft
Libba Lawrence (l0lawrence) wants to merge 1 commit into
Libba Lawrence (l0lawrence) wants to merge 1 commit into
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
microsoft-github-policy-service
Bot
added
the
emitter:client:python
commit: |
Contributor
|
All changed packages have been documented.
Show changes
|
|
You can try these changes here
|
Contributor
Python emitter diffBaseline No changes to generated output. Rendered diff: inline on the run summary, or the emitter-diff-html artifact. Informational check (eng/emitter-diff); does not block the PR. |
| location: bodyParam.kind, | ||
| clientName: bodyParam.isGeneratedName ? "body" : getClientName(bodyParam), | ||
| wireName: bodyParam.isGeneratedName ? "body" : bodyParam.name, | ||
| wireName: bodyParam.isGeneratedName ? "body" : bodyParam.serializedName, |
Member
Author
There was a problem hiding this comment.
@ body params clientNames were using bodyParam.name was the tcgc renamed value, not the name on the wire
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix Python sample generation losing REST example body values when an explicit body parameter is renamed with TCGC
@clientName.Use the body's
serializedNamefor its code-modelwireNameinstead of the SDK-renamedname. The SDK-facingclientNameremains unchanged, and generated body parameters retain the existing"body"fallback.For an example keyed by
resource,@clientName("topic", "python")now produces:Previously, the sample contained placeholder
"str"values.Coverage and validation
The generator currently emits synchronous REST samples only; no async sample coverage is claimed. Local reproduction artifacts are excluded from this PR.
Fixes #12433.