Skip to content

Object with index as keys should not equal array #17

Closed
inspect-js/node-deep-equal
#65
Closed
Object with index as keys should not equal array#17
inspect-js/node-deep-equal
#65

Description

@a-b-r-o-w-n
a-b-r-o-w-n
opened on Aug 17, 2015
expect({ 0: 'hello', 1: 'world' }).toEqual([ 'hello', 'world' ]);

I don't think this should pass, but it does. Is there something I am missing, or is this not intended?

Activity

  1. mjackson commented on Sep 11, 2015

    @mjackson
    mjackson
    on Sep 11, 2015
    Owner

    JavaScript arrays are actually objects (with special semantics). I see no reason why that test shouldn't pass.

  2. mjackson
    closed this as completedon Sep 11, 2015

  3. aaronjensen commented on Sep 11, 2015

    @aaronjensen
    aaronjensen
    on Sep 11, 2015

    Node core no longer agrees: https://github.com/nodejs/LTS/wiki/Breaking-changes-between-v0.12-and-next-LTS-release#assert-check-object-prototype-in-assertdeepequal

    nodejs/node#621

    Object.getPrototypeOf([0]) === Object.getPrototypeOf({'0': 0})
false
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions