Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR type
PR information
Fixes #modelscope/twinkle#407
dev 的 _check_sp_hf_feasibility 已对 padding_free x 非 flash-attn 做了校验
("padding_free requires a flash attention kernel"),但非 packed(padding-mask
layout)x 非 flash-attn 组合没有任何校验。该组合在 NPU 上训练启动后于第一个
forward_backward 深崩(507035,异步爆发点在 twinkle/processor/base.py 的 packed
序列判定/解包路径,堆栈无法定位到真实根因)。
触发矩阵(20 步训练级验证):fa2+packed ✓ / fa2+非packed ✓ /
sdpa+packed(被现有校验禁止)/ sdpa+非packed ✗(本 issue)。
Experiment results
Paste your experiment result here(if needed).
Checklist