Skip to content

Copy metadata-filter defaults before per-call modification - #102

Open
jdotc1 wants to merge 1 commit into
moloney:masterfrom
jdotc1:fix/isolate-cli-metadata-filter-defaults
Open

jdotc1 wants to merge 1 commit into
moloney:masterfrom
jdotc1:fix/isolate-cli-metadata-filter-defaults

Conversation

@jdotc1

@jdotc1 jdotc1 commented Oct 14, 2026

Copy link
Copy Markdown

The CLI filter-construction block aliases the module-level include/exclude lists and extends them in place. An override in one CLI invocation can therefore change the defaults used by later invocations in the same Python process.

Copy both lists before extending them with per-call arguments. Explicit overrides retain their behavior; separate CLI processes are unaffected. The independently constructed default_meta_filter is outside this change, and this is not a complete de-identification fix.

Validation reuses the existing dcmstack entries in baseline-receipt.json (FAIL: a prior call changed subsequent defaults) and patched-receipt.json (PASS). Those synthetic checks execute the source filter-construction block twice with a stubbed filter factory, covering the explicit override and the next call's original defaults. The patch was applied to the actual checkout and source-reviewed. No checks were rerun; package integration, DICOM import, and de-identification behavior were not tested.

@jdotc1

jdotc1 commented Oct 23, 2026

Copy link
Copy Markdown
Author

Thank you for considering this contribution. When you have a chance, I would appreciate a review of this PR. I’m happy to clarify anything that would be helpful, and I appreciate your time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant