Repository navigation
Conversation
Author
|
Thank you for considering this contribution. When you have a chance, I would appreciate a review of this PR. I’m happy to clarify anything that would be helpful, and I appreciate your time. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The CLI filter-construction block aliases the module-level include/exclude lists and extends them in place. An override in one CLI invocation can therefore change the defaults used by later invocations in the same Python process.
Copy both lists before extending them with per-call arguments. Explicit overrides retain their behavior; separate CLI processes are unaffected. The independently constructed
default_meta_filteris outside this change, and this is not a complete de-identification fix.Validation reuses the existing
dcmstackentries inbaseline-receipt.json(FAIL: a prior call changed subsequent defaults) andpatched-receipt.json(PASS). Those synthetic checks execute the source filter-construction block twice with a stubbed filter factory, covering the explicit override and the next call's original defaults. The patch was applied to the actual checkout and source-reviewed. No checks were rerun; package integration, DICOM import, and de-identification behavior were not tested.