Skip to content

[api-minor] Don't re-layout the textLayer on update (PR 20492 follow-up) - #22045

Merged
Snuffleupagus merged 1 commit into
mozilla:masterfrom
Snuffleupagus:textLayer-update-without-layout
Oct 5, 2026
Merged

Snuffleupagus merged 1 commit into
mozilla:masterfrom
Snuffleupagus:textLayer-update-without-layout

Conversation

@Snuffleupagus

Copy link
Copy Markdown
Collaborator

PR #20492 removed the special handling of marked content, which means that the viewer changing the --scale-factor should now be sufficient to update the textLayer and that it's no longer necessary to re-layout all of its elements.

@Snuffleupagus

Copy link
Copy Markdown
Collaborator Author

This seems almost too easy, so I cannot escape the feeling that I've overlooked something trivial in my quick testing.
/cc @calixteman

@Snuffleupagus

Copy link
Copy Markdown
Collaborator Author

/botio-linux preview

@moz-tools-bot

Copy link
Copy Markdown
Collaborator

From: Bot.io (Linux m4)


Received

Command cmd_preview from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/1b97f7ac1922821/output.txt

@codecov-commenter

codecov-commenter commented Oct 1, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.29%. Comparing base (35f87e3) to head (049f59a).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #22045      +/-   ##
==========================================
- Coverage   90.30%   90.29%   -0.01%     
==========================================
  Files         269      269              
  Lines       67371    67362       -9     
==========================================
- Hits        60838    60825      -13     
- Misses       6533     6537       +4     
Flag Coverage Δ
browsertest 66.07% <ø> (+0.01%) ⬆️
fonttest 8.95% <ø> (ø)
integrationtest 69.23% <ø> (-0.02%) ⬇️
unittest 59.87% <ø> (+<0.01%) ⬆️
unittestcli 58.39% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@moz-tools-bot

Copy link
Copy Markdown
Collaborator

From: Bot.io (Linux m4)


Success

Full output at http://54.241.84.105:8877/1b97f7ac1922821/output.txt

Total script time: 1.39 mins

Published

@github-actions

github-actions Bot commented Oct 1, 2026 •

Copy link
Copy Markdown
Contributor

Reference tests

Results for 049f59a (run, references from mozilla/pdf.js.refs@7ac8f26399).

Platform Status Tests Total runtime Errors Different FBF No reference Report
Linux ✅ 1381 10m 42s 0 0 0 0
Windows ✅ 1381 13m 53s 0 0 0 0

The report is kept for 30 days and replaced by the next run.

sync-pdfs-for-pdf-js Bot pushed a commit to mozilla/pdf.js.refs that referenced this pull request Oct 1, 2026

@calixteman calixteman left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you.

…w-up)

PR 20492 removed the special handling of marked content, which means that the viewer changing the `--scale-factor` should now be sufficient to update the `textLayer` and that it's no longer necessary to re-layout all of its elements.
@Snuffleupagus
Snuffleupagus force-pushed the textLayer-update-without-layout branch from 053b60d to 049f59a Compare October 5, 2026 09:43
@Snuffleupagus
Snuffleupagus marked this pull request as ready for review October 5, 2026 09:44
sync-pdfs-for-pdf-js Bot pushed a commit to mozilla/pdf.js.refs that referenced this pull request Oct 5, 2026
@Snuffleupagus
Snuffleupagus merged commit 289cb1d into mozilla:master Oct 5, 2026
22 checks passed
@Snuffleupagus
Snuffleupagus deleted the textLayer-update-without-layout branch October 5, 2026 11:43

This branch was previously deployed

1 inactive deployment
sync_pdfs — 049f59a3 Deployed Oct 5, 2026 by Snuffleupagus via request #260
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants