Repository navigation
Directly call Set.prototype.delete in the ChunkedStreamManager code - #22065
Merged
timvandermeij merged 1 commit intoOct 3, 2026
Merged
timvandermeij merged 1 commit into
timvandermeij merged 1 commit into
Conversation
There's no point in first checking if a value exists in a Set before deleting it, and this is just a left-over from before the code used Maps and Sets. Also, remove a couple of unnecessary comments describing how `Set.prototype.add` works (when those where added there wasn't much Set usage in the code-base).
Snuffleupagus
temporarily deployed
to
sync_pdfs
October 3, 2026 16:39 — with
GitHub Actions
Inactive
Contributor
Reference testsResults for 1316be0 (run, references from mozilla/pdf.js.refs@669ca76240).
The report is kept for 30 days and replaced by the next run. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #22065 +/- ##
==========================================
+ Coverage 90.36% 90.38% +0.01%
==========================================
Files 269 269
Lines 67228 67227 -1
==========================================
+ Hits 60751 60762 +11
+ Misses 6477 6465 -12
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
sync-pdfs-for-pdf-js Bot
pushed a commit
to mozilla/pdf.js.refs
that referenced
this pull request
Oct 3, 2026
timvandermeij
approved these changes
Oct 3, 2026
timvandermeij
left a comment
Collaborator
There was a problem hiding this comment.
r=me, with passing CI. Thanks!
This was referenced Nov 3, 2026
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There's no point in first checking if a value exists in a Set before deleting it, and this is just a left-over from before the code used Maps and Sets.
Also, remove a couple of unnecessary comments describing how
Set.prototype.addworks (when those where added there wasn't much Set usage in the code-base).