Skip to content

Directly call Set.prototype.delete in the ChunkedStreamManager code - #22065

Merged
timvandermeij merged 1 commit into
mozilla:masterfrom
Snuffleupagus:ChunkedStreamManager-Set-direct-delete
Oct 3, 2026
Merged

timvandermeij merged 1 commit into
mozilla:masterfrom
Snuffleupagus:ChunkedStreamManager-Set-direct-delete

Conversation

@Snuffleupagus

Copy link
Copy Markdown
Collaborator

There's no point in first checking if a value exists in a Set before deleting it, and this is just a left-over from before the code used Maps and Sets.

Also, remove a couple of unnecessary comments describing how Set.prototype.add works (when those where added there wasn't much Set usage in the code-base).

There's no point in first checking if a value exists in a Set before deleting it, and this is just a left-over from before the code used Maps and Sets.

Also, remove a couple of unnecessary comments describing how `Set.prototype.add` works (when those where added there wasn't much Set usage in the code-base).
@github-actions

github-actions Bot commented Oct 3, 2026 •

Copy link
Copy Markdown
Contributor

Reference tests

Results for 1316be0 (run, references from mozilla/pdf.js.refs@669ca76240).

Platform Status Tests Total runtime Errors Different FBF No reference Report
Linux ⚠️ 1381 11m 8s 0 1 0 0 view differences
Windows ✅ 1381 14m 17s 0 0 0 0

The report is kept for 30 days and replaced by the next run.

@codecov-commenter

codecov-commenter commented Oct 3, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.38%. Comparing base (d0991a0) to head (1316be0).
⚠️ Report is 4 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #22065      +/-   ##
==========================================
+ Coverage   90.36%   90.38%   +0.01%     
==========================================
  Files         269      269              
  Lines       67228    67227       -1     
==========================================
+ Hits        60751    60762      +11     
+ Misses       6477     6465      -12     
Flag Coverage Δ
browsertest 66.19% <100.00%> (+<0.01%) ⬆️
fonttest 8.96% <ø> (ø)
integrationtest 69.38% <100.00%> (+0.01%) ⬆️
unittest 59.69% <100.00%> (-0.01%) ⬇️
unittestcli 58.20% <100.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

sync-pdfs-for-pdf-js Bot pushed a commit to mozilla/pdf.js.refs that referenced this pull request Oct 3, 2026

@timvandermeij timvandermeij left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me, with passing CI. Thanks!

@timvandermeij
timvandermeij merged commit 2581d8f into mozilla:master Oct 3, 2026
23 checks passed
@Snuffleupagus
Snuffleupagus deleted the ChunkedStreamManager-Set-direct-delete branch October 4, 2026 13:51

This branch was previously deployed

1 inactive deployment
sync_pdfs — 1316be0d Deployed Oct 3, 2026 by Snuffleupagus via request #249
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants