Skip to content

Improve the find bar integration tests - #22069

Merged
timvandermeij merged 3 commits into
mozilla:masterfrom
timvandermeij:find-bar-coverage
Oct 24, 2026
Merged

timvandermeij merged 3 commits into
mozilla:masterfrom
timvandermeij:find-bar-coverage

Conversation

@timvandermeij

Copy link
Copy Markdown
Collaborator

The commit messages contain more details about the individual changes.

@codecov-commenter

codecov-commenter commented Oct 4, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.51%. Comparing base (850b390) to head (0e3a000).
⚠️ Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #22069      +/-   ##
==========================================
+ Coverage   90.48%   90.51%   +0.03%     
==========================================
  Files         277      277              
  Lines       68366    68366              
==========================================
+ Hits        61858    61880      +22     
+ Misses       6508     6486      -22     
Flag Coverage Δ
integrationtest 69.49% <ø> (+0.04%) ⬆️
unittestcli 58.66% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Comment thread test/integration/find_spec.mjs Resolved
Comment thread test/integration/find_spec.mjs Resolved
Comment thread test/integration/find_spec.mjs Resolved
Comment thread test/integration/find_spec.mjs Resolved
Comment thread test/integration/find_spec.mjs Resolved
@timvandermeij
timvandermeij force-pushed the find-bar-coverage branch 2 times, most recently from 3cf7746 to d9b38d7 Compare October 6, 2026 19:10
@timvandermeij
timvandermeij force-pushed the find-bar-coverage branch 2 times, most recently from 4212096 to c8a4af2 Compare October 12, 2026 18:50
@timvandermeij
timvandermeij force-pushed the find-bar-coverage branch 4 times, most recently from 5991b5d to c6a4189 Compare October 18, 2026 19:00
…tion tests

This refactoring makes the existing tests more compact/expressive, and
makes it easier to add more find bar tests in a next commit without
having to duplicate this logic more often.
This makes the test names more consistent to improve clarity on what the
tests aim to check, and avoids using duplicate test names to make
discovery of e.g. failed tests easier in the logs.
This commit brings code coverage for the `web/pdf_find_bar.js` file to
100% by covering all missing cases, which include:

- searching with no results;
- searching with multiple results;
- highlighting all search results using keyboard navigation;
- closing the find bar via the toolbar button and the Escape key.

@calixteman calixteman left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you, it's better like this.

@timvandermeij
timvandermeij merged commit 4c99803 into mozilla:master Oct 24, 2026
12 checks passed
@timvandermeij
timvandermeij deleted the find-bar-coverage branch October 24, 2026 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants