Skip to content

Fix initial radio button selection (PR 12637 follow-up) - #22148

Merged
calixteman merged 1 commit into
mozilla:masterfrom
calixteman:radio-initial-checked
Oct 11, 2026
Merged

calixteman merged 1 commit into
mozilla:masterfrom
calixteman:radio-initial-checked

Conversation

@calixteman

Copy link
Copy Markdown
Contributor

Compare export values with data.value because _value is still null during construction. This fixes isBoxChecked and action selection when a later widget is initially selected, plus the "Off" toggle in two-button groups.

Compare export values with data.value because _value is still null during
construction. This fixes isBoxChecked and action selection when a later
widget is initially selected, plus the "Off" toggle in two-button groups.
sync-pdfs-for-pdf-js Bot pushed a commit to mozilla/pdf.js.refs that referenced this pull request Oct 11, 2026
@github-actions

github-actions Bot commented Oct 11, 2026 •

Copy link
Copy Markdown
Contributor

Viewer preview

🗑️ Viewer previews removed.

@codecov-commenter

codecov-commenter commented Oct 11, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.30%. Comparing base (da95557) to head (3f745c0).

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #22148   +/-   ##
=======================================
  Coverage   90.30%   90.30%           
=======================================
  Files         277      277           
  Lines       67949    67949           
=======================================
+ Hits        61360    61361    +1     
+ Misses       6589     6588    -1     
Flag Coverage Δ
browsertest 66.21% <ø> (-0.01%) ⬇️
fonttest 8.98% <ø> (ø)
integrationtest 69.28% <ø> (ø)
unittest 60.20% <ø> (+<0.01%) ⬆️
unittestcli 58.29% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Snuffleupagus Snuffleupagus left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me, thanks.

@calixteman
calixteman merged commit fdf6950 into mozilla:master Oct 11, 2026
26 checks passed
@calixteman
calixteman deleted the radio-initial-checked branch October 11, 2026 21:21
sync-pdfs-for-pdf-js Bot pushed a commit to mozilla/pdf.js.refs that referenced this pull request Oct 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants