Skip to content

Handle invalid canvas sizes in worker rendering (PR 21860 follow-up) - #22155

Merged
calixteman merged 1 commit into
mozilla:masterfrom
calixteman:renderer-worker-degenerate-sizes
Oct 12, 2026
Merged

calixteman merged 1 commit into
mozilla:masterfrom
calixteman:renderer-worker-degenerate-sizes

Conversation

@calixteman

Copy link
Copy Markdown
Contributor

Skip zero-sized page bitmaps while still sending annotation canvases. Skip separate annotation canvases with non-finite dimensions. Continue rendering if an interim frame cannot be sent.

@codecov-commenter

codecov-commenter commented Oct 12, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 88.23529% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.33%. Comparing base (0d0635e) to head (83bffae).
⚠️ Report is 14 commits behind head on master.

Files with missing lines Patch % Lines
src/display/renderer_worker.js 77.77% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #22155      +/-   ##
==========================================
+ Coverage   90.23%   90.33%   +0.09%     
==========================================
  Files         277      277              
  Lines       67972    67981       +9     
==========================================
+ Hits        61335    61409      +74     
+ Misses       6637     6572      -65     
Flag Coverage Δ
browsertest 66.23% <70.58%> (+0.02%) ⬆️
fonttest 8.98% <ø> (ø)
integrationtest 69.29% <82.35%> (+0.13%) ⬆️
unittest 60.38% <76.47%> (+0.02%) ⬆️
unittestcli 58.32% <50.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

sync-pdfs-for-pdf-js Bot pushed a commit to mozilla/pdf.js.refs that referenced this pull request Oct 12, 2026
@github-actions

github-actions Bot commented Oct 12, 2026 •

Copy link
Copy Markdown
Contributor

Viewer preview

🗑️ Viewer previews removed.

@github-actions

github-actions Bot commented Oct 12, 2026 •

Copy link
Copy Markdown
Contributor

Reference tests

Results for 635cf3f (run, references from mozilla/pdf.js.refs@23d8c278ca).

Platform Status Tests Total runtime Errors Different FBF No reference Report
Linux ⚠️ 1393 10m 16s 0 1 0 0 view differences
Windows ⚠️ 1393 15m 39s 0 1 0 0 view differences

The report is kept for 30 days and replaced by the next run.

@Snuffleupagus Snuffleupagus left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me, with passing browser-tests; thanks.

Comment thread src/display/renderer_worker.js Resolved
sync-pdfs-for-pdf-js Bot pushed a commit to mozilla/pdf.js.refs that referenced this pull request Oct 12, 2026
@calixteman
calixteman force-pushed the renderer-worker-degenerate-sizes branch from 635cf3f to 87575a0 Compare October 12, 2026 18:13
sync-pdfs-for-pdf-js Bot pushed a commit to mozilla/pdf.js.refs that referenced this pull request Oct 12, 2026
Skip zero-sized page bitmaps while still sending annotation canvases.
Skip separate annotation canvases with non-finite dimensions.
Continue rendering if an interim frame cannot be sent.
@calixteman
calixteman force-pushed the renderer-worker-degenerate-sizes branch from 87575a0 to 83bffae Compare October 12, 2026 18:18
sync-pdfs-for-pdf-js Bot pushed a commit to mozilla/pdf.js.refs that referenced this pull request Oct 12, 2026
@calixteman
calixteman merged commit e1412d3 into mozilla:master Oct 12, 2026
22 checks passed
sync-pdfs-for-pdf-js Bot pushed a commit to mozilla/pdf.js.refs that referenced this pull request Oct 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants